search

willi19 / swpp202301-compiler-team6

MIT License
0 stars 0 forks source link

[Sprint 2, NFC] Improving tests and resolving issues #24

Closed goranmoomin closed 1 year ago

goranmoomin commented 1 year ago

Honestly these are miscellaneous improvements, but the major one is that with this we can now separate the FileCheck tests for each pass.

Please ping me if explanations are needed.

This is a WIP PR, more commits might be added.

sharaelong commented 1 year ago

FYI our NFC PR has to be only one for each sprint!

sharaelong commented 1 year ago

Also remove llvm components from CMakeLists.txt inside backend parts. Related: https://github.com/snu-sf-class/swpp202301/issues/72

goranmoomin commented 1 year ago

Also remove llvm components from CMakeLists.txt inside backend parts.

I'm quite sure that if we get to rebase our repository with the same modifications, the commit will automatically disappear; if that seems not the case tomorrow, I'll remove the commit.

sharaelong commented 1 year ago

Can you add features that our pass is correct? (i.e. whether output of program after pass applied is same as output of baseline) It is critical but as I remember we haven't carried out this kind of job until now.

goranmoomin commented 1 year ago

Can you add features that our pass is correct?

benchmark.sh checks the pass.

sharaelong commented 1 year ago

Then LGTM!

germanium32 commented 1 year ago

L G T M~

willi19 commented 1 year ago

LGTM