willia4 / wsdl2objc

Automatically exported from code.google.com/p/wsdl2objc
MIT License
1 stars 0 forks source link

Binding named "binding" breaks the generator #84

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
If WSDL uses a binding called "binding" the wsdl writer will generate code that 
does not compile. In 
order to not change the web service it is required to either modify the binding 
name or modify 
USBinding.

My patch to fix the problem is attached.

Original issue reported on code.google.com by grundpri...@gmail.com on 3 May 2010 at 11:26

Attachments:

GoogleCodeExporter commented 9 years ago
I would prefer not changing the binding name across the board. You should add a 
prefix only in the specific 
instance of the binding being called "binding".

Also, why don't you set:

NSString* format = @"bnd_%@";

instead of

NSString* format = [NSString stringWithCString: "bnd_%@"];

Original comment by hasse...@gmail.com on 3 May 2010 at 11:52

GoogleCodeExporter commented 9 years ago
You are right, I totally forgot about the normal initialization.

There would be another possibility to avoid change the binding name, by 
renaming the variable names in the 
templates. Let me get back to you regarding the amount of changes required.

Original comment by grundpri...@gmail.com on 3 May 2010 at 11:57

Attachments:

GoogleCodeExporter commented 9 years ago
Ok, I changed the member variable name form binding to binding_ and replaced 
all occurrences.

See the attached patch.

Original comment by grundpri...@gmail.com on 3 May 2010 at 12:10

Attachments:

GoogleCodeExporter commented 9 years ago
Before we patch across the board, can you post the exact compile error(s) that 
the code generates? Maybe 
there's a more elegant solution. 

Original comment by hasse...@gmail.com on 3 May 2010 at 12:23