search

william-iq397 / nuxt-app

0 stars 0 forks source link

Review No. 1 #1

Open Gruce opened 1 year ago

Gruce commented 1 year ago

Hello,

Hope you are doing well.

Goal Image: image

Achieved Image: image

Many issues including:

  1. You are showing your skills as a frontend developer. We are not expecting less than making a better version of the goal image. You have many issues in the visionary things like (paddings, margins, colors, etc.). You don't need to make new revolutionary user interface but we have gave you the UI.
  2. In logic things, you made many mistakes too, including, making incremental and decremental functions that can effect on one item with no cart or anyway to save the previous choices, so, practically this is not efficient.

And many more.

Here is a few questions:

  1. Rate yourself (1-10) in UI and share with me your excellent UI, you have ever made. If you have less confidence about your previous UI please make one and share a link for it.
  2. What is the benefits of autoImports in nuxt.config.ts for pinia while you have imported it manually ?
  3. What is the benefits of Lazy of Header in layouts/default.vue ?
  4. What is the purpose of products/[id].vue page - Is it connected with the other pages?
  5. Rate your work on the current project (CLOTHO POS) - Which is of course not Resto (what we really need).

Thank you, Hassan.

william-iq397 commented 1 year ago

1 - I don't have the UI figma or anything(which I would be greatful if you can give me).

2 - many things in the project are from an existent project like product(id) is one of theme.

3 - I would rate myself 2/10 but it could ve 10/10 if I have a all the materials of the UI not just an image.

4 - I didn't find any food API, every API I fetch it gives me null.

5 - thanks for your issue it helped realize too many things, and I will work on it.

Gruce commented 1 year ago

Hello again,

  1. You already have the UI provided as a picture (actually no need for Figma).
  2. You may generate your own fake data with id 🤗.
  3. What do you mean with "all the materials of the UI"? And why not just an image? is it hard to you not to use Figma or what? what if you run a frontend of a team with no Ui/Ux specialist in that team?
  4. Make your own API then.

To be honest, all the points you've mentioned are excuses, you showed me that your most valuable skill is excuse. I can't see other skills. Anything else was just normal, and I don't like normal people to be honest.

Thank you for your transparency, Hassan.