Doesn't pause video on sites with iframes

william-reed / Pipit-extension

The Chrome / Firefox companion extension for Pipit - bringing native macOS Picture in Picture to Chrome and Firefox for (almost) any video

1 stars 1 forks source link

Doesn't pause video on sites with iframes #2

Open inickt opened 6 years ago

inickt commented 6 years ago

For example: https://helpx.adobe.com/photoshop/how-to/color-tone-adjustments.html?playlist=/ccx/v1/collection/product/photoshop/segment/photographer/explevel/advanced/applaunch/orientation/collection.ccx.js?ref=helpx.adobe.com

Looks like the video tag is in an iframe. We should add logic if we can't find the video element to search the iframes.

william-reed commented 6 years ago

Not so sure we are going to be able to pause it because of the cross site scripting going on. Since the adobe site and video aren't on the same domain, events coming from the extension to the iframe are considered cross-origin and blocked

inickt commented 6 years ago

Thats what I was worried about 🙁