search

william-reed / Pipit-extension

The Chrome / Firefox companion extension for Pipit - bringing native macOS Picture in Picture to Chrome and Firefox for (almost) any video
1 stars 1 forks source link

URL scheme link opening breaks some webpages #3

Open inickt opened 6 years ago

inickt commented 6 years ago

For example, BBC's page breaks when the link is added to the page

william-reed commented 6 years ago

are you referring to the video breaking or the whole page? Trying to test this now and it seems like the video player goes black after opening in pipit

inickt commented 6 years ago

Just the video player. If you wanted to go back to the player and resume there it wouldn't work

william-reed commented 6 years ago

its an iframe as well so i wonder if that has anything to do with it breaking as you navigate to a new link inside of the iframe? hmm

inickt commented 6 years ago

I could be wrong, but I thought we were adding the a tag to the original page so it shouldn't be effecting the contents inside of the iframe. Unless some weird loading thing is happening. Although the Adobe video in #2 is also in an iframe and doesn't have the same issue.