search

williambl / piston-control

MIT License
0 stars 1 forks source link

Tentatively got selective stickiness working #5

Closed supersaiyansubtlety closed 3 years ago

supersaiyansubtlety commented 4 years ago

Does not collect tags, but has a whole data structure for to efficiently get stickiness relations, made to be built from tags.

williambl commented 4 years ago

Thanks :D , I'll take a look at this.

Btw, your git config seems to be messed up - the commit says it's by BuildTools, not you.

supersaiyansubtlety commented 4 years ago

Oh, wonder if that's something to do with Intellij... Thanks for pointing that out.

williambl commented 3 years ago

@supersaiyansubtlety I've amended your commit so it shows up as being authored by you. It seems like your git config had been modified by the Spigot BuildTools system.

supersaiyansubtlety commented 3 years ago

Thanks, I've since fixed my git config

supersaiyansubtlety commented 3 years ago

By the way, I see your 'Replace IterableHashSet and IterableBlockTagMap' commit, just thought I'd let you know that since I made the PR I've learned more about the data structures available in the libraries already included by minecraft+fabric, and based on the name of your new data structure, com.google.common.collect.LinkedHashMultimap may be a good fit.

williambl commented 3 years ago

based on the name of your new data structure, com.google.common.collect.LinkedHashMultimap may be a good fit ~@supersaiyansubtlety

The data structure I'm using is the com.google.common.collect.HashMultimap :) I think the only difference between that and the Linked... version is that LinkedHashMultimap retains the order that things are added, which doesn't seem too useful for this.

Google's Guava adds so many different data structures with quite subtle differences like that, haha.

supersaiyansubtlety commented 3 years ago

The other difference is that it's actually meant for iterating over, and the iteration is more efficient. Not sure if you need that though.

Anyways, glad to see the feature's being worked on again : )