volar v2 no longer works

sho-87 commented 8 months ago

Problem description

it seems that as of volar > 2.0 some additional dependencies are needed for lsp to work. see thread here: https://github.com/vuejs/language-tools/issues/3925

it seems that a new package @vue/typescript-plugin needs to be bundled and referenced as part of setting up tsserver and volar. as of right now, none of the language capabilities are working with vue3 files

Why do you think this is an issue with mason-lspconfig.nvim?

Unsure if this should be reported here or over at nvim-lspconfig, but I figured mason makes sense as new packages now need to be installed as part of the setup

Neovim version (>= 0.7)

NVIM v0.9.5 Build type: RelWithDebInfo LuaJIT 2.1.1703942320 Compilation: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe /MD /Zi /O2 /Ob1 -W3 -wd4311 -wd4146 -DUNIT_TESTING -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_DEPRECATE -D_WIN32_WINNT=0x0602 -DMSWIN -DINCLUDE_GENERATED_DECLARATIONS -ID:/a/neovim/neovim/.deps/usr/include/luajit-2.1 -ID:/a/neovim/neovim/.deps/usr/include -ID:/a/neovim/neovim/.deps/usr/include -ID:/a/neovim/neovim/build/src/nvim/auto -ID:/a/neovim/neovim/build/include -ID:/a/neovim/neovim/build/cmake.config -ID:/a/neovim/neovim/src -ID:/a/neovim/neovim/.deps/usr/include -ID:/a/neovim/neovim/.deps/usr/include -ID:/a/neovim/neovim/.deps/usr/include -ID:/a/neovim/neovim/.deps/usr/include -ID:/a/neovim/neovim/.deps/usr/include -ID:/a/neovim/neovim/.deps/usr/include -ID:/a/neovim/neovim/.deps/usr/include

system vimrc file: "$VIM\sysinit.vim" fall-back for $VIM: "C:/Program Files (x86)/nvim/share/nvim"

Operating system/version

Windows 11

I've manually reviewed the Nvim LPS client log (`:LspLog`) to find potential errors

[X] Yes

I've recently downloaded the latest plugin version of mason.nvim, mason-lspconfig.nvim, and nvim-lspconfig

[X] Yes

Affected language servers

volar

Steps to reproduce

add "vue-language-server" to mason ensure_installed and open a vue3 file

Actual behavior

using any capabilities like go to definition/references don't do anything. same with things like diagnostics

Expected behavior

for capabilities to work

LspInfo

Client: tsserver (id: 1, bufnr: [3])
    filetypes:       javascript, javascriptreact, javascript.jsx, typescript, typescriptreact, typescript.tsx
    autostart:       true
    root directory:  D:/SprungHub
    cmd:             C:\Users\simon\AppData\Local\nvim-data\mason\bin\typescript-language-server.CMD --stdio

 Client: volar (id: 2, bufnr: [3])
    filetypes:       vue
    autostart:       true
    root directory:  D:/SprungHub
    cmd:             C:\Users\simon\AppData\Local\nvim-data\mason\bin\vue-language-server.CMD --stdio

(tsserver is from trying to install the new plugin myself but quite finicky...)

LspLog

No, volar is found and attached properly. only some messages about dynamicRegistration

Healthcheck

mason.nvim ~
- OK mason.nvim version v1.10.0
- OK PATH: prepend
- OK Providers: 
  mason.providers.registry-api
  mason.providers.client
- OK neovim version >= 0.7.0

mason.nvim [Registries] ~
- OK Registry `github.com/mason-org/mason-registry version: 2024-03-05-seemly-truck` is installed.

mason.nvim [Core utils] ~
- WARNING unzip: not available
  - ADVICE:
    - spawn: unzip failed with exit code - and signal -. unzip is not executable
- WARNING wget: not available
  - ADVICE:
    - spawn: wget failed with exit code - and signal -. wget is not executable
- OK curl: `curl 8.4.0 (Windows) libcurl/8.4.0 Schannel WinIDN
`
- WARNING gzip: not available
  - ADVICE:
    - spawn: gzip failed with exit code - and signal -. gzip is not executable
- OK tar: `bsdtar 3.6.2 - libarchive 3.6.2 zlib/1.2.5.f-ipp liblzma/5.2.5 bz2lib/1.0.8 libzstd/1.5.4 
`
- OK pwsh: `7.4.1 Microsoft Windows 10.0.22631 Win32NT
`
- OK 7z: `7-Zip 23.01 (x64) : Copyright (c) 1999-2023 Igor Pavlov : 2023-06-20
`

mason.nvim [Languages] ~
- WARNING cargo: not available
  - ADVICE:
    - spawn: cargo failed with exit code - and signal -. cargo is not executable
- WARNING Composer: not available
  - ADVICE:
    - spawn: composer.bat failed with exit code - and signal -. composer.bat is not executable
- WARNING PHP: not available
  - ADVICE:
    - spawn: php failed with exit code - and signal -. php is not executable
- WARNING luarocks: not available
  - ADVICE:
    - spawn: luarocks failed with exit code - and signal -. luarocks is not executable
- WARNING Ruby: not available
  - ADVICE:
    - spawn: ruby failed with exit code - and signal -. ruby is not executable
- WARNING javac: not available
  - ADVICE:
    - spawn: javac failed with exit code - and signal -. javac is not executable
- WARNING java: not available
  - ADVICE:
    - spawn: java failed with exit code - and signal -. java is not executable
- WARNING julia: not available
  - ADVICE:
    - spawn: julia failed with exit code - and signal -. julia is not executable
- WARNING RubyGem: not available
  - ADVICE:
    - spawn: gem.cmd failed with exit code - and signal -. gem.cmd is not executable
- OK node: `v21.6.1
`
- OK Go: `go version go1.22.0 windows/amd64`
- OK python: `Python 3.11.8
`
- OK npm: `10.2.4`
- OK pip: `pip 24.0 from C:\Program Files\Python311\Lib\site-packages\pip (python 3.11)

`
- OK python venv: `Ok`

mason.nvim [GitHub] ~
- OK GitHub API rate limit. Used: 3. Remaining: 57. Limit: 60. Reset: 3/4/2024 7:29:52 PM.
  Install and authenticate via gh-cli to increase rate limit.

Screenshots or recordings

No response

catgoose commented 8 months ago

I removed volar from auto install and edited package version in ~/.local/share/nvim/mason/packages/vue-language-server to old volar version.

StevenJPx2 commented 8 months ago

Volar 2 breaks typescript support because it moves it to a separate package. Very annoying, but they did it.

This is the way to setup TS Server to handle vue files.

For TLDR:

require'lspconfig'.tsserver.setup{
  init_options = {
    plugins = {
      {
        name = "@vue/typescript-plugin",
        location = "/usr/local/lib/node_modules/@vue/typescript-plugin",
        languages = {"javascript", "typescript", "vue"},
      },
    },
  },
  filetypes = {
    "javascript",
    "typescript",
    "vue",
  },
}

-- You must make sure volar is setup
-- e.g. require'lspconfig'.volar.setup{}
-- See volar's section for more information

For Mac, this config is not drag-and-drop, especially the location.

To set that up properly, run npm -g ls @vue/typescript-plugin after installing it globally and you will get something like this:

/opt/homebrew/lib
└── @vue/typescript-plugin@2.0.6

Location will now change to /opt/homebrew/lib/node_modules/@vue/typescript-plugin.

Ideally, Mason should handle this in the background by installing it in the bin/ folder. Of course, this is a large change that went unnoticed for a plugin that handles many LSPs.

Hope this helps!

My entire morning and afternoon went into fixing this, haha!

GR3YH4TT3R93 commented 8 months ago

Here's a slightly modified solution that uses the included Mason handlers and NVM for managing node.

This uses npm i -g @vue/typescript-plugin as above but includes a home variable for more portability and uses nvm to avoid needing to install node packages system-wide for increased security/ dependency maintainability.

local home = os.getenv("HOME")

["tsserver"] = function()
  require("lspconfig").tsserver.setup({
    init_options = {
      plugins = {
        {
          name = "@vue/typescript-plugin",
          -- Change this to the location the plugin is installed to
          location = home .. "/.nvm/versions/node/v21.7.1/lib/node_modules/@vue/typescript-plugin",
          languages = { "javascript", "typescript", "vue" },
        },
      },
    },
    filetypes = {
      "javascript",
      "typescript",
      "vue",
    },
  })
end,

sho-87 commented 8 months ago

fyi volar has been changed again and no longer needs typescript-plugin (https://github.com/vuejs/language-tools/pull/4119). heres the new setup ive found that works, but it seems to be much more error prone than v1.8.7 (lsp reporting wrong positions for diagnostics etc):

require("lspconfig").volar.setup({
            filetypes = { "typescript", "javascript", "javascriptreact", "typescriptreact", "vue" },
            root_dir = util.root_pattern("package.json"),
            init_options = {
              vue = {
                hybridMode = false,
              },
              typescript = {
                tsdk = get_typescript_server_path(vim.fn.getcwd()),
              },
            },
          })

StevenJPx2 commented 8 months ago

What. But this is breaking changes again, so all of this was pointless?

catgoose commented 8 months ago

What. But this is breaking changes again, so all of this was pointless?

Yeah I don't even know how I'm supposed to configure lspconfig now.

sho-87 commented 8 months ago

Yeah I don't even know how I'm supposed to configure lspconfig now.

theres a pretty useful writeup here: https://github.com/vuejs/language-tools?tab=readme-ov-file#community-integration

but im not sure how https://github.com/vuejs/language-tools/issues/4148 will affect nvim, so will have to wait and see

Roninii commented 8 months ago

I'm not sure what's going on with the ts plugin, but when I save a .vue file, it replaces the contents of the entire file with blank lines. Commenting out the init_options in the setup block for tsserver seems to fix it, but then none of the features of Volar work.

I've tried both, the solution here in the neovim lspconfig docs, as well as the instructions from above using mason_registry.get_package, but both options result in the same behavior.

My setup for reference. (Note, home is a variable declared earlier in the file ):

        tsserver = {
          -- Add Vue support to the TS LSP.
          init_options = {
            plugins = {
              {
                name = '@vue/typescript-plugin',
                location = home .. '/.nvm/versions/node/v18.18.0/lib/node_modules/@vue/typescript-plugin',
                languages = { 'javascript', 'typescript', 'vue' },
              },
            },
          },
          filetypes = {
            'javascript',
            'typescript',
            'vue',
          },

I also tried following the new guidelines for setting up non hybrid mode, but the instructions are a little unclear re: "make sure you pass the location" for non-global TS installations.

sho-87 commented 8 months ago

@Roninii I had that issue as well. its due to this bug: https://github.com/vuejs/language-tools/issues/4066

GR3YH4TT3R93 commented 8 months ago

This is the latest working config for vue/ts support using Mason handlers (you'll want to disable the tsserver config for vue):

        ["volar"] = function()
          require("lspconfig").volar.setup({
            filetypes = { "vue", "javascript", "typescript", "javascriptreact", "typescriptreact" },
            init_options = {
              vue = {
                hybridMode = false,
              },
              typescript = {
                tsdk = vim.fn.getcwd() .. "/node_modules/typescript/lib",
              },
            },
          })
        end,

Roninii commented 8 months ago

@Roninii I had that issue as well. its due to this bug: vuejs/language-tools#4066

Thank you 🙏 . Disabling formatting for tsserver fixed my issue.

ugoa commented 7 months ago

@GR3YH4TT3R93 Thank you for the config! After I changed from

tsdk = vim.fn.getcwd() .. "node_modules/typescript",

to

tsdk = vim.fn.getcwd() .. "/node_modules/typescript/lib",

as the link you shared, everything works!

catgoose commented 7 months ago

@GR3YH4TT3R93 Thank you for the config! After I changed from
tsdk = vim.fn.getcwd() .. "node_modules/typescript",
to
tsdk = vim.fn.getcwd() .. "node_modules/typescript/lib",
as the link you shared, everything works!

For some reason I have to do:

tsdk = vim.fn.getcwd() .. "/node_modules/typescript/lib",

k0mpreni commented 7 months ago

I tried this config but didn't seem to make it work, I do have types for a component for example, I still can go to the definition (may not be related) and also don't have an error when a required prop is missing. Is it working with you @catgoose ? If yes, do you have maybe some dotfiles that I could look at?

catgoose commented 7 months ago

I tried this config but didn't seem to make it work, I do have types for a component for example, I still can go to the definition (may not be related) and also don't have an error when a required prop is missing. Is it working with you @catgoose ? If yes, do you have maybe some dotfiles that I could look at?

Yeah everything is working for me.

https://github.com/catgoose/nvim/blob/main/lua/plugins/lspconfig.lua#L143-L161

I use Volar for .vue files and tsserver for .ts

I also wrote a plugin to make goto-definition work as one would expect:

https://github.com/catgoose/vue-goto-definition.nvim

k0mpreni commented 7 months ago

Oh my bad, seem to be working on a brand new vue project, just on a specific project it load the shim definition for components instead the types but shouldn't be related.

Curs3W4ll commented 5 months ago

you'll want to disable the tsserver config for vue

I was wondering what is the best way to do this. The main problem is the following:

You do not want to use tsserver on .vue files (you have volar): ✅ Handled
You do not want to use volar on .ts[js...] files if not in a vuejs project: ❌ I do not know how to do this
You do not want to use tsserver on .ts[js...] (you have volar) when being in a vuejs project: ❌ I do not know how to do this
But you do want to use tsserver on projects that are not vuejs projects: ❌ I do not know how to do this

Currently I have a hacky workaround, but this is making me use volar on all my TS projects (even those without vue)

I'm basically creating an auto command to automatically stop tsserver when launching if volar is already launched, or being launched

local function isLSPClientActive(name)
    return #vim.lsp.get_clients({ name = name }) > 0
end
vim.api.nvim_create_autocmd("LspAttach", {
    callback = function(args)
        local client = vim.lsp.get_client_by_id(args.data.client_id)
        if client == nil then
            return
        end

        -- NOTE: Disable tsserver when volar is running (or will run two times the same lsp)
        if client.name == "volar" then
            if isLSPClientActive("tsserver") then
                require("neokit.array").forEach(vim.lsp.get_clients({ name = "tsserver" }), function(elem)
                    elem.stop()
                end)
            end
        elseif client.name == "tsserver" then
            if isLSPClientActive("volar") then
                client.stop()
            end
        end
    end,
})

GR3YH4TT3R93 commented 5 months ago

you'll want to disable the tsserver config for vue

I was wondering what is the best way to do this. The main problem is the following:

* You do not want to use `tsserver` on `.vue` files (you have `volar`): ✅ Handled

* You do not want to use `volar` on `.ts[js...]` files if not in a vuejs project: ❌ I do not know how to do this

* You do not want to use `tsserver` on `.ts[js...]` (you have `volar`) when being in a vuejs project: ❌ I do not know how to do this

* But you do want to use `tsserver` on projects that are not vuejs projects: ❌ I do not know how to do this

In order to not use volar on .ts[js...] files that are outside of a vue/nuxt project, you need to make determining the root_dir more strict:

        ["volar"] = function()
          require("lspconfig").volar.setup({
            filetypes = { "vue", "javascript", "typescript", "javascriptreact", "typescriptreact" },
            -- restrict volar to only attach when in a vue/nuxt project
            root_dir = require("lspconfig").util.root_pattern(
              "vue.config.js",
              "vue.config.ts",
              "nuxt.config.js",
              "nuxt.config.ts"
            ),
            init_options = {
              vue = {
                hybridMode = false,
              },
              typescript = {
                tsdk = vim.fn.getcwd() .. "/node_modules/typescript/lib",
              },
            },
          })
        end,

The issue now seems to be with the last two issues of not wanting/wanting tsserver to attach to .ts[js...] files in vue/angular/svelte projects due to the nature of any expected tsserver root_dir pattern being found in all projects that contain typescript including vue/angular/svelte projects.

k0mpreni commented 5 months ago

How would the ts setup be @GR3YH4TT3R93 ? If I just add this volar setup, I get duplicated diagnostics, from volar and from tsserver (in vue and ts files)

GR3YH4TT3R93 commented 5 months ago

How would the ts setup be @GR3YH4TT3R93 ? If I just add this volar setup, I get duplicated diagnostics, from volar and from tsserver (in vue and ts files)

Tbh, right now I just don't have tsserver installed and if I need it, I can just install it real quick

catgoose commented 5 months ago

you'll want to disable the tsserver config for vue

I was wondering what is the best way to do this. The main problem is the following:
* You do not want to use `tsserver` on `.vue` files (you have `volar`): ✅ Handled

* You do not want to use `volar` on `.ts[js...]` files if not in a vuejs project: ❌ I do not know how to do this

* You do not want to use `tsserver` on `.ts[js...]` (you have `volar`) when being in a vuejs project: ❌ I do not know how to do this

* But you do want to use `tsserver` on projects that are not vuejs projects: ❌ I do not know how to do this
In order to not use volar on .ts[js...] files that are outside of a vue/nuxt project, you need to make determining the root_dir more strict:
        ["volar"] = function()
          require("lspconfig").volar.setup({
            filetypes = { "vue", "javascript", "typescript", "javascriptreact", "typescriptreact" },
            -- restrict volar to only attach when in a vue/nuxt project
            root_dir = require("lspconfig").util.root_pattern(
              "vue.config.js",
              "vue.config.ts",
              "nuxt.config.js",
              "nuxt.config.ts"
            ),
            init_options = {
              vue = {
                hybridMode = false,
              },
              typescript = {
                tsdk = vim.fn.getcwd() .. "/node_modules/typescript/lib",
              },
            },
          })
        end,
The issue now seems to be with the last two issues of not wanting/wanting tsserver to attach to .ts[js...] files in vue/angular/svelte projects due to the nature of any expected tsserver root_dir pattern being found in all projects that contain typescript including vue/angular/svelte projects.

This is the only way I can get volar/tsserver to play well together. Though I use neoconf to control when volar is loaded.

bobbyrahmanda13 commented 5 months ago


    local mason_registry = require('mason-registry')
    local vue_language_server_path = mason_registry.get_package('vue-language-server'):get_install_path() .. '/node_modules/@vue/language-server'

    mason_lspconfig.setup_handlers({

      function(server_name)
        lspconfig[server_name].setup({
          capabilities =capabilities,
        })
      end,

      ["tsserver"] = function()

        lspconfig["tsserver"].setup({

          capabilities = capabilities,
          root_dir = util.root_pattern('tsconfig.json', 'package.json', 'nuxt.config.ts', 'uno.config.ts', '.git'),
          init_options = {
            plugins = {
              {
                name = "@vue/typescript-plugin",
                location = vue_language_server_path,
                languages = {'vue'}
              },
            }
          },
        })

      end,

      ["volar"] = function()

        local volar_typescript = '/home/rahman/.local/share/nvim/mason/packages/typescript-language-server/node_modules/typescript/lib'

        lspconfig["volar"].setup({
          capabilities = capabilities,
          root_dir = util.root_pattern("package.json","vue.config.ts","nuxt.config.ts","uno.config.ts"),
          init_options = {
            vue = {
              hybridMode = false,
            },
            typescript = {
              tsdk = volar_typescript,
            },
          },
        })

      end

work for me, diagnostic no double

xarthurx commented 5 months ago

Any official solution to this?

catgoose commented 5 months ago

Any official solution to this?

Install @vue/typescript-plugin locally or globally.

This is my setup:

https://github.com/catgoose/nvim/blob/main/lua/plugins/lspconfig.lua

GR3YH4TT3R93 commented 5 months ago

There is currently an issue with volar versions 2.0.20 and above. If you haven't updated, don't. If you have, :MasonInstall vue-language-server@2.0.19 will get you back up and running for now

Eckhardt-D commented 5 months ago

There is currently an issue with volar versions 2.0.20 and above. If you haven't updated, don't. If you have, :MasonInstall vue-language-server@2.0.19 will get you back up and running for now

This fixed LSP in .vue files for me, thanks!

GR3YH4TT3R93 commented 5 months ago

It should be safe to update volar now, the following config is working for me, adjust as needed:

        ["volar"] = function()
          require("lspconfig").volar.setup({
            -- NOTE: Uncomment to enable volar in file types other than vue.
            -- (Similar to Takeover Mode)

            -- filetypes = { "vue", "javascript", "typescript", "javascriptreact", "typescriptreact", "json" },

            -- NOTE: Uncomment to restrict Volar to only Vue/Nuxt projects. This will enable Volar to work alongside other language servers (tsserver).

            -- root_dir = require("lspconfig").util.root_pattern(
            --   "vue.config.js",
            --   "vue.config.ts",
            --   "nuxt.config.js",
            --   "nuxt.config.ts"
            -- ),
            init_options = {
              vue = {
                hybridMode = false,
              },
              -- NOTE: This might not be needed. Uncomment if you encounter issues.

              -- typescript = {
              --   tsdk = vim.fn.getcwd() .. "/node_modules/typescript/lib",
              -- },
            },
          })
        end,

        ["tsserver"] = function()
          local mason_packages = vim.fn.stdpath("data") .. "/mason/packages"
          local volar_path = mason_packages .. "/vue-language-server/node_modules/@vue/language-server"

          require("lspconfig").tsserver.setup({
            -- NOTE: To enable Hybrid Mode, change hybrideMode to true above and uncomment the following filetypes block.
            -- WARN: THIS MAY CAUSE HIGHLIGHTING ISSUES WITHIN THE TEMPLATE SCOPE WHEN TSSERVER ATTACHES TO VUE FILES

            -- filetypes = { "typescript", "javascript", "javascriptreact", "typescriptreact", "vue" },
            init_options = {
              plugins = {
                {
                  name = "@vue/typescript-plugin",
                  location = volar_path,
                  languages = { "vue" },
                },
              },
            },
          })
        end,

GR3YH4TT3R93 commented 4 months ago

Bonus inlay hints setup for anyone interested:

        ["volar"] = function()
          require("lspconfig").volar.setup({
            -- NOTE: Uncomment to enable volar in file types other than vue.
            -- (Similar to Takeover Mode)

            -- filetypes = { "vue", "javascript", "typescript", "javascriptreact", "typescriptreact", "json" },

            -- NOTE: Uncomment to restrict Volar to only Vue/Nuxt projects. This will enable Volar to work alongside other language servers (tsserver).

            -- root_dir = require("lspconfig").util.root_pattern(
            --   "vue.config.js",
            --   "vue.config.ts",
            --   "nuxt.config.js",
            --   "nuxt.config.ts"
            -- ),
            init_options = {
              vue = {
                hybridMode = false,
              },
              -- NOTE: This might not be needed. Uncomment if you encounter issues.

              -- typescript = {
              --   tsdk = vim.fn.getcwd() .. "/node_modules/typescript/lib",
              -- },
            },
            settings = {
              typescript = {
                inlayHints = {
                  enumMemberValues = {
                    enabled = true,
                  },
                  functionLikeReturnTypes = {
                    enabled = true,
                  },
                  propertyDeclarationTypes = {
                    enabled = true,
                  },
                  parameterTypes = {
                    enabled = true,
                    suppressWhenArgumentMatchesName = true,
                  },
                  variableTypes = {
                    enabled = true,
                  },
                },
              },
            },
          })
        end,

        ["ts_ls"] = function()
          local mason_packages = vim.fn.stdpath("data") .. "/mason/packages"
          local volar_path = mason_packages .. "/vue-language-server/node_modules/@vue/language-server"

          require("lspconfig").ts_ls.setup({
            -- NOTE: To enable hybridMode, change HybrideMode to true above and uncomment the following filetypes block.
            -- WARN: THIS MAY CAUSE HIGHLIGHTING ISSUES WITHIN THE TEMPLATE SCOPE WHEN TSSERVER ATTACHES TO VUE FILES

            -- filetypes = { "typescript", "javascript", "javascriptreact", "typescriptreact", "vue" },
            init_options = {
              plugins = {
                {
                  name = "@vue/typescript-plugin",
                  location = volar_path,
                  languages = { "vue" },
                },
              },
            },
            settings = {
              typescript = {
                inlayHints = {
                  includeInlayParameterNameHints = "all",
                  includeInlayParameterNameHintsWhenArgumentMatchesName = true,
                  includeInlayFunctionParameterTypeHints = true,
                  includeInlayVariableTypeHints = true,
                  includeInlayVariableTypeHintsWhenTypeMatchesName = true,
                  includeInlayPropertyDeclarationTypeHints = true,
                  includeInlayFunctionLikeReturnTypeHints = true,
                  includeInlayEnumMemberValueHints = true,
                },
              },
            },
          })
        end,

Rich107 commented 3 months ago

@GR3YH4TT3R93 Thank you so much, been at this for days reading out of date info with the little time I have in the evening!

GR3YH4TT3R93 commented 3 months ago

@Rich107 glad I could help! One thing I forgot to add to the snippet above is how to activate inlay hints so here's my keymap for it:

Local opts = { noremap = true, silent = true }
vim.keymap.set({ "n", "i" }, "gI", function()
  vim.lsp.inlay_hint.enable(not vim.lsp.inlay_hint.is_enabled())
end, opts)

This will toggle inlay hints in normal and insert mode with "gI"

Rich107 commented 3 months ago

@Rich107 glad I could help! One thing I forgot to add to the snippet above is how to activate inlay hints so here's my keymap for it:
Local opts = { noremap = true, silent = true }
vim.keymap.set({ "n", "i" }, "gI", function()
  vim.lsp.inlay_hint.enable(not vim.lsp.inlay_hint.is_enabled())
end, opts)
This will toggle inlay hints in normal and insert mode with "gI"

Thank you, I will have a look tonight.

Still got an issue where go to definition will not leave a .Vue file to go to a .ts file (where my pinia store is)

Any pointers would be appreciated. I am new to neovim. Just got my vim motions Sorted in jetbrains ide and slowly moving over.

Rich107 commented 3 months ago

@GR3YH4TT3R93 sorry bother you,

After playing with this config, I realised that I can't jump to definition from a .Vue file that has a const exported from a .ts file say my pinia store. Jump to definition works from .Vue to .Vue quite well though but only with relative imports.

Likewise when in the pinia store I can't list references of where it is used in the .Vue file.

Any time or places I could look to troubleshoot this would be appreciated.

GR3YH4TT3R93 commented 3 months ago

@Rich107 Could you provide an example repo I could test your issue on please?

Rich107 commented 3 months ago

Thank you @GR3YH4TT3R93

https://github.com/Rich107/neovim-config

My Vue project is private but if it helps to reproduce I would be more than happy to send you an invite.

Rich107 commented 3 months ago

@GR3YH4TT3R93 I am sorry to nudge you but I have been having a fresh go at following: https://github.com/neovim/nvim-lspconfig/blob/master/doc/server_configurations.md#vue-support

But if anything I only make it worse. If you could have a look at my config I would really appreciate it.

One thing I wanted to ask was why the location difference between what you have and what the docs say? In the docs they point at the @vue/typescript-plugin for Vue where as you point to @vue/language-server.

  init_options = {
    plugins = {
      {
        name = "@vue/typescript-plugin",
        location = "/usr/local/lib/node_modules/@vue/typescript-plugin",
        languages = {"javascript", "typescript", "vue"},
      },
    },
  },
  filetypes = {
    "javascript",
    "typescript",
    "vue",
  },
}

-- You must make sure volar is setup
-- e.g. require'lspconfig'.volar.setup{}
-- See volar's section for more information

Side not I checked my versions of Volar and the tsserver plugin and they are both at: 2.0.29

Rich107 commented 3 months ago

@GR3YH4TT3R93 oh my days... the project I was in did not have a tsconfig.json or tsconfig.config.json file. Adding those fixed my go to definition and go to references.

My question about the location above still stands as that does seem to work but does not match the docs that I can see so would love to understand why that is. But you config @GR3YH4TT3R93 is sound. :)

GR3YH4TT3R93 commented 3 months ago

My question about the location above still stands as that does seem to work but does not match the docs that I can see so would love to understand why that is. But you config @GR3YH4TT3R93 is sound. :)

Sorry for the late reply, I've been out sick. But to answer your question, my config was adapted from the vuejs/language-tools docs along with lsp-setup.nvim docs for inlay hints

williamboman / mason-lspconfig.nvim