search

williamboman / nvim-lsp-installer

Further development has moved to https://github.com/williamboman/mason.nvim!
https://github.com/williamboman/mason.nvim
Apache License 2.0
2k stars 123 forks source link

Replace ocaml-language-server with ocaml-lsp #474

Closed adlrwbr closed 2 years ago

adlrwbr commented 2 years ago

Problem description

The OCaml language server NPM package is 4 years outdated and has since been relocated to ocaml/ocaml-lsp. Rather than using NPM, I suggest installing the server with the officially supported OCaml Package Manager (opam). The opam-installed binary is named ocaml-lsp, which is how I initially discovered this inconsistency. Lastly, I believe ocaml-lsp supports development with the Reason language, so the supported languages table should reflect that change.

Neovim version (>= 0.6)

NVIM v0.6.1 Build type: Release LuaJIT 2.0.5 Compiled by builduser

Operating system/version

Linux laptop 5.12.19-1-MANJARO #1 SMP PREEMPT Tue Jul 20 20:57:37 UTC 2021 x86_64 GNU/Linux

I've recently downloaded the latest plugin version of both nvim-lsp-installer and nvim-lspconfig

Affected language servers

ocaml-language-server

Actual behavior

The OCaml language server is being installed from NPM and is out of date and not maintained.

Expected behavior

The latest OCaml language server should be installed from official sources.

LspInstallInfo output

No response

Installation log

NA (the install is successful)

Healthcheck

NA (the install is successful)

Screenshots

No response

williamboman commented 2 years ago

Ah :+1:. I believe this is the ocamllsp server in lspconfig. I think it'd make sense to deprecate ocamlls in favor of ocamllsp.

harrydt commented 2 years ago

I can take a stab at this