Open s1n7ax opened 2 years ago
Hello! I believe the nvim-lsp-installer settings were added before jdtls introduced the jdtls
wrapper script. In order to avoid breaking changes for people using jdtls
via nvim-lsp-installer I'm not too sure about completely removing the current behaviour. I'd be happy to accept a PR that makes nvim-lsp-installer behave a bit better with jdtls
(while not changing default behaviour)! (also as a sidenote, going forward I'll be concentrating my efforts on https://github.com/williamboman/mason.nvim which will be stabilized soon)
@williamboman mason will replace this?
Is your feature request related to a problem? Please describe.
lspconfig allows
jvm_args
andworkspace
to be overridden by settingconfig.init_options
.nvim-lsp-installer seems to be using
config.vmargs
&vim.env.WORKSPACE
.Since nvim-lsp-installer allows to be setup through the regular
lspconfig.setup()
it would be nice to respectlspconfig
config.Describe the solution you'd like
Following config should change set
-additional_arg
JVM option and should change the workspace from~/workspace
to~/.cache/jdtls
.Describe potential alternatives you've considered
To export
DEFAULT_VMARGS
, a possible solution would be, movingDEFAULT_VMARGS
tonvim-lsp-installer/servers/jdtls/defaults.lua
.