williamcioffi / sattagutils

utils for manupulating sat tag output
0 stars 0 forks source link

`load_dap_output` doesn't pass on `stream_delim` and maybe should just be removed? #75

Open williamcioffi opened 3 years ago

williamcioffi commented 3 years ago

load_dap_output calls load_tag but doesn't pass the stream_delim parameter.

That's easy to fix, but the larger issue is does load_dap_output might make a ton of sense. It is designed for splitting up tags when there is one big mixed together dap output with multiple tags/ptts, but there are lot of vagaries of formatting and assumptions that maybe shouldn't be hidden in here and if the user needs to do this sort of thing maybe it should be left up to them.