search

williamckha / spicetify-fluent

Spicetify theme inspired by Microsoft's Fluent Design
MIT License
284 stars 17 forks source link

Various font fixes #31

Closed rlaphoenix closed 2 years ago

rlaphoenix commented 2 years ago

This seems to, at least on my end, fix #11.

However, some references to text elements I was not able to locate in the app, so I could not fully test. Regardless, the result is more consistent overall.

Before:

image

After:

image

(pay attention to the Playlist minuet text under AAAAAAAAA... as well as Songs, the g is no longer clipped.)

While the before/after may look like only one or two clips and overflows were fixed, the actual end result is much more consistent across the UI. For one, all overflow specifications were removed entirely and instead text clips were fixed properly via a line-height specification.

This makes all text across the board correct, but its positioning may now be ever so slightly altered. If you compare the before/after pics closely, you can see text everywhere has changed ever so slightly in position in relatively unpredictable ways, but it does look correct on my end.

williamckha commented 2 years ago

Looks good to me. Thanks a lot for all of your work and fixes, I appreciate it.