williamckha / spicetify-fluent

Spicetify theme inspired by Microsoft's Fluent Design
MIT License
275 stars 17 forks source link

Follow system theme #67

Open LuminarySage opened 2 years ago

LuminarySage commented 2 years ago

📝 Provide a description of the new feature

Basically use the light mode when system is in light mode and dark when the system is in dark mode

➕ Additional Information

No response

rlaphoenix commented 2 years ago

I don't know if this can be done with spicetify, but even if it can it may not be wanted by the user. They may specifically want an alternate theme to their system.

LuminarySage commented 2 years ago

You should make it toggleable then. And yes it's possible bc this spicetify theme does it and it makes it toggleable too: https://github.com/JulienMaille/dribbblish-dynamic-theme#follow-system-darklight-theme-powershell

rlaphoenix commented 2 years ago

That method does seem to require patching of the Spotify exe which will complicate things, especially if users do not want to modify the exe.

However, more problematic is the Fluent light theme is very experimental and doesn't work very well even on supported Spotify versions. It will need to be worked on before this is implemented.

LuminarySage commented 2 years ago

I'm glad it's considered anyway

nimsandu commented 2 years ago

is this feature really useful? i mean user can change config to light theme using shell and that process is a one time process making things complicated will kill the calmness of fluent designing system

special note- @williamckha is a great creator i respect him and even im using his theme as my themes base i still following his principles

LuminarySage commented 2 years ago

It is useful if you have auto dark mode. It's gonna get tiring really fast to open up the terminal twice a day every day to change the theme

nimsandu commented 2 years ago

@Jnss98b Yah that makes sense But this should go smoothly as a step by step process

First we have to develop light theme more fluent and less buggy

LuminarySage commented 2 years ago

Yeah I get that. There's no rush at all. I was just answering @nimsandu