williamfiset / Algorithms

A collection of algorithms and data structures
MIT License
16.84k stars 4.29k forks source link

JUnit 5 Migration #381

Closed syoon2 closed 1 year ago

syoon2 commented 1 year ago

The current impl is using Junit 4 and is WAI. Please send a PR if you want to upgrade to Junit 5, altough that might breaks other tests along the way

https://github.com/williamfiset/Algorithms/blob/master/build.gradle#L35

Originally posted by @williamfiset in https://github.com/williamfiset/Algorithms/issues/294#issuecomment-985931731

This PR migrates all JUnit 4-based test suites to JUnit 5. This includes:

This does not include:

Side note: Due to an upstream "issue" with google/truth, JUnit 4 is indirectly included as a test dependency regardless of this PR 😢 - see https://github.com/google/truth/issues/333 for context.

syoon2 commented 1 year ago

@williamfiset Just a kind ping :)

ptahchiev commented 1 year ago

Any chance to get this merged?