Closed syoon2 closed 1 year ago
The current impl is using Junit 4 and is WAI. Please send a PR if you want to upgrade to Junit 5, altough that might breaks other tests along the way https://github.com/williamfiset/Algorithms/blob/master/build.gradle#L35 Originally posted by @williamfiset in https://github.com/williamfiset/Algorithms/issues/294#issuecomment-985931731
The current impl is using Junit 4 and is WAI. Please send a PR if you want to upgrade to Junit 5, altough that might breaks other tests along the way
https://github.com/williamfiset/Algorithms/blob/master/build.gradle#L35
Originally posted by @williamfiset in https://github.com/williamfiset/Algorithms/issues/294#issuecomment-985931731
This PR migrates all JUnit 4-based test suites to JUnit 5. This includes:
This does not include:
SkipListTest.java
Side note: Due to an upstream "issue" with google/truth, JUnit 4 is indirectly included as a test dependency regardless of this PR 😢 - see https://github.com/google/truth/issues/333 for context.
@williamfiset Just a kind ping :)
Any chance to get this merged?
This PR migrates all JUnit 4-based test suites to JUnit 5. This includes:
This does not include:
SkipListTest.java
(which was written only using JUnit 4 in the first place)Side note: Due to an upstream "issue" with google/truth, JUnit 4 is indirectly included as a test dependency regardless of this PR 😢 - see https://github.com/google/truth/issues/333 for context.