williamflaherty / pearing

KCSW project
Other
1 stars 0 forks source link

If we hit an unexpected exception here, send a 500 #13

Closed danielcash closed 9 years ago

danielcash commented 9 years ago

Writing some view tests, I noticed we're not changing the status code when we hit an exception. Since this handler is catching all unhandled exceptions, we should really be sending a 500 with success=False.

Hopefully this will get cleaned up once we have some better exception handling in place, but for now this is a quick fix. I need this before I can check in an additional API test.

/review @Mimimiel @williamflaherty