search

williamflaherty / pearing

KCSW project
Other
1 stars 0 forks source link

Let's use Github properly #2

Closed danielcash closed 9 years ago

danielcash commented 9 years ago

Let's get a consistent and maintainable workflow going in Github. Even with just a few people touching the code, we really should have some sort of process.

I propose:

  1. No more pushing directly to williamflaherty/pearing.
  2. Let's all fork the williamflaherty/pearing repo.
  3. After committing changes to your local pearing branch, create a pull request.
  4. Let's get something like travis-ci running to watch our tests. If the tests fail on a pull request, do not merge.
  5. Don't merge the pull request until someone else leaves a +1 comment. We really shouldn't skip this, but if it's a hot-fix or a revert, then it's probably okay.

Pretty simple, but should make things a little bit safer and smoother.

williamflaherty commented 9 years ago

I'm gonna go ahead and close this issue because you're right about using the fork/pull/merge work flow with github. It gives us at least a semblance of QA and should keep me (:grin:) from having to deal with broken API stuff when I get to certain points within the app.

I'll make a couple of new issues for setting up a server to host the code and get testing setup on it.