search

williamgilpin / pypdb

A Python API for the RCSB Protein Data Bank (PDB)
MIT License
309 stars 77 forks source link

Added verbose bools to optionally suppress printing output to screen #58

Closed jthornton-0 closed 1 year ago

jthornton-0 commented 1 year ago

First off, thank you for the great API! An issue I have noticed is using the programme with significant searches, the output produced by printing the search query and .fasta sequence search has been filling my slurm (task manager for supercomputers) logs (and making them very large files) and it would be nice to provide the user an option to toggle output off.

The docstring for the two affected functions has been updated, this is my first pull request so if there is anything I haven't done please let me know and I will make changes if this branch is acceptable.

williamgilpin commented 1 year ago

Hi, thank you for fixing this! I noticed that you closed the PR---did you find a bug, or should I re-open it. As long as the demos notebook runs then I'm sure it's all good. Thanks

jthornton-0 commented 1 year ago

Hey, I need to modify it slightly - there was a bug in the @dataclass's with it as they weren't expecting an extra variable. It is trivial to fix and I will repon with the modified code later on, thank you. I really like this package so do not mind going through the issues users have posted to see what modifications can be made.