search

williamhunter / topy

Topology Optimization using Python
Other
481 stars 130 forks source link

Revert "Apply pep8 codestyle" #47

Closed mlaradji closed 4 years ago

mlaradji commented 4 years ago

Changelog

Changed

williamhunter commented 4 years ago

I'm not reviewing Pull Requests because I'm not actively working on ToPy anymore, so I'm doing this in good faith. The last time I accepted a pull request (also without reviewing) it broke ToPy, but this pull seems to fix that? So I'm merging it. Not the best approach, I know, but I also don't want to stop people from contributing.

mlaradji commented 4 years ago

@williamhunter I believe this one fixes it. I was able to run a couple of the examples, though I didnt wait for them to finish (they take too long on my PC).

How about we have some form of CI? We can test whether all examples run with every pull request created, and perhaps also compare the results and/or time taken with some standard we set.

williamhunter commented 4 years ago

Yes, that sounds good, if you want to do that and you have time for it, please go ahead.

On Fri, 21 Feb 2020 at 02:32, Mohamed Laradji notifications@github.com wrote:

@williamhunter https://github.com/williamhunter I believe this one fixes it. I was able to run a couple of the examples, though I didnt wait for them to finish (they take too long on my PC).

How about we have some form of CI? We can test whether all examples run with every pull request created, and perhaps also compare the results and/or time taken with some standard we set.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/williamhunter/topy/pull/47?email_source=notifications&email_token=ADMS2ULRJRQ3ULCQQEEEIGTRD4OI7A5CNFSM4KYFWS42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMRCNCY#issuecomment-589440651, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMS2UL6K6H4QO63ERDQSE3RD4OI7ANCNFSM4KYFWS4Q .