Closed Spudz76 closed 10 years ago
That commit is a backward-compatible style one. No usage changes other than you probably should use identify() instead if you need to. Will update docs, assuming this fix is accepted.
Tested the "vanilla" join() operation, I don't have a services-enabled (infected?) server to bother testing the identify() on.
PR applied, use .nick('ircHax0r')
like normal for simple NICK
command, or .identify('ircHax0r','lam3passwd')
for the NickServ style. If you pass a password in to .nick()
per the old docs, it works backwardly compatible, but don't do that.
On a vanilla ircd (
ircd-hybrid
in my case) without any services, the built-innick()
method does not work properly, as nothing ever sends back anyNOTICE
event, and no password is required.Motion to rename the "services compatible" method to
identify()
(since the responding event is'identified'
) and change thenick()
method to actually just do a normal NICK command without all the NickServ fluff.I suppose a backward compatible mode could be forged if anyone passes more than one argument to the
nick()
method (old usage). But strongly prefer the above solution as it is more consistent logically.