prevent the module from throwing uncatchable errors

williamkapke / mongo-mock

Let's pretend we have a real MongoDB

MIT License

240 stars 74 forks source link

prevent the module from throwing uncatchable errors #136

Open kjarmicki opened 3 years ago

kjarmicki commented 3 years ago

Hello,

There are situations when this module throws errors from inside of setTimeout callback that are impossible to catch from the outside and cause a process exit (unless caught with global uncaughtException handler, but I don't want that :wink:). This is the case with any uncaught error thrown inside of a callback scheduled with asyncish.

This PR fixes that. I've chosen a method that seemed least invasive to the codebase.

kjarmicki commented 3 years ago

Thanks for the approve @shaunburdick :slightly_smiling_face: Is there a chance to merge and release this patch?

kjarmicki commented 3 years ago

Hey @shaunburdick can we please merge and release this patch? :pray: