search

williamlamjy / pe

0 stars 0 forks source link

Can add a meal with a name without letters and still be a valid name #5

Open williamlamjy opened 2 years ago

williamlamjy commented 2 years ago

Perhaps throw an exception for name to only have letters?

Screenshot 2021-11-12 at 4.26.29 PM.png

soc-se-bot commented 2 years ago

Team's Response

We allow all inputs for meals, even without having letters to allow for the user's convenience in typing out any name they wish to use to describe their meal. It is completely up to the user and we do not want to limit the user's ability to describe their meals.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This response doesnt make much sense as an empty name is not a meal? And what meal would have no letters? This functionality makes little sense with this justification and I dont think there is much of a justification to be able to add a meal with no name as a valid meal. Instead an error should be handled and thrown here to let the user know that you cannot add an empty meal.