search

williamlamjy / pe

0 stars 0 forks source link

Error not thrown when i key in an invalid command #8

Open williamlamjy opened 2 years ago

williamlamjy commented 2 years ago

Screenshot 2021-11-12 at 4.34.10 PM.png

I mistyped the d as c instead and there is no error thrown despite having two "/c" formatters inside the same line. The instrument is added as well.

nus-se-bot commented 2 years ago

Team's Response

Stated in known limitation section that separators should be entered once:

image.png

Possible duplicate, documentation bug due to not being specific that the first instance of input will be taken.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unclear error message

image.png

It is unclear which attribute a positive integer is supposed to be entered, since all attributes are left blank here.

[original: nus-cs2113-AY2122S1/pe-interim#391] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

/d and /t takes in a date and time in the format dd/mm/yyyy and hh:mm, while /c takes in calories burned as a positive integer. A such it can be inferred that the calories is the issue, since implementation wise, it is the first exception thrown.

That being said, the message could have been more intuitive, so this will be accepted.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Both bugs are different reasonings with different errors. In my case, this command should not even be accepted as the formatting is completely wrong with a duplicate formatter. Instead shouldnt this be handled with the appropriate error and error message? Even if you did mention this in the user guide there should still be an error thrown here instead of accepting my incorrect command. Imagine if the user faces the same scenario as I have and sees that his command got accepted in, he would assume he managed to add this workout at the timing he has placed by just assuming he typed it right but this is not the case. Instead an incorrect workout is added in.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.High]

Reason for disagreement: Very low would indicate aesthetic or appearance based issues. Lack of accounting for major formatting issues would definitely cause multiple inconveniences in a day with simple mistypings. As seen from the other response, there seems to be many different issues coming out of similar formatting issues and many errors that are not accounted for with lack of error messages to guide the user.