add 2 more IR pairs to match report

[GoogleCodeExporter]

...

Original issue reported on code.google.com by Nimda...@gmail.com on 9 Feb 2010 at 3:56

[GoogleCodeExporter]

on top of that I will add the parsing in the match report.  Since they are 
nested,
they will have to be parsed like the injuries I believe.

Original comment by funnyfin...@hotmail.com on 9 Feb 2010 at 10:47

[GoogleCodeExporter]

r599.

Please do some testing on this, William.
Please close when verified works, thanks.

Original comment by Nimda...@gmail.com on 15 Feb 2010 at 11:04

• Changed state: Started

[GoogleCodeExporter]

Also, William, please add the proper code in your upload class so that multiple 
rolls
are passed to match::entry().

Original comment by Nimda...@gmail.com on 15 Feb 2010 at 11:07

[GoogleCodeExporter]

..change the $input to match::entry() to use

'ir1_d1' => ...,
'ir1_d2' => ...,
'ir2_d1' => ...,
'ir2_d2' => ...,
'ir3_d1' => ...,
'ir3_d2' => ...,

INSTEAD OF THE OLD

'ir_d1' => ...,
'ir_d2' => ...,

until the template is complete simply pass a zero (0) as the above ir2_* and 
ir3_*
fields.

Original comment by Nimda...@gmail.com on 15 Feb 2010 at 11:11

[GoogleCodeExporter]

ALSO, since I don't provide upgrade code in upgrade.php between revisions, you 
will
have to run these two SQL statements manually:

ALTER TABLE match_data CHANGE ir_d1 ir1_d1 TINYINT UNSIGNED NOT NULL DEFAULT 0;
ALTER TABLE match_data CHANGE ir_d2 ir1_d2 TINYINT UNSIGNED NOT NULL DEFAULT 0;

Do this BEFORE running upgrade.php !!!!

This is only needed once.

Original comment by Nimda...@gmail.com on 15 Feb 2010 at 11:32

[GoogleCodeExporter]

Does changing the owner notify necrosis automatically?

Necrosis - when you update the stats, would you just update it with the new 
skills
rolls and not the other stuff you added to the template?  You can keep the 
stuff in
the template, but I want to move slower in adding the newer stuff just to be 
able to
see what may go wrong easier.

Original comment by funnyfin...@hotmail.com on 18 Feb 2010 at 1:28

[GoogleCodeExporter]

Don't think so :-/. Haven't seen him in a while?

Original comment by Nimda...@gmail.com on 18 Feb 2010 at 5:56

[GoogleCodeExporter]

The new template makes the following changes:-

New Player Stats

Added to the Offensive stats category
safe_throws     cp_st   Number of times an interception was canceled by safe 
throw.

Changed tentacles stats to Skill stats and added

foul_appearance_rolls   foul_a  Number of times foul appearance was rolled
foul_appearance_successes       foul    Number of times foul appearance 
succeeded
dauntless_rolls dau_a   Number of times dauntless was rolled
dauntless_successes     dau     Number of times dauntless succeeded
shadowing_rolls shad_a  Number of times shadowing was attempted
shadowing_successes     shad    Number of times shadowing succeeded

Added new category for bomb throwing, these are still being tested cant get the
inflicted version of them yet

bombs_throw_attempts    bomb_a  Number of times a bomb throw attempts
bombs_thrown    bomb_t  Number of times a bomb was thrown
sustained_bomb_effect   sbo_ef  Number of times effected by a bomb
sustained_bomb_stun     sbo_st  Number of times stunned by a bomb
sustained_bomb_ko       sbo_ko  Number of times knocked out by a bomb
sustained_bomb_bh       sbo_bh  Number of times badly hurt by a bomb
sustained_bomb_si       sbo_si  Number of times seriously hurt by a bomb
sustained_bomb_kill     sbo_ki  Number of times killed by a bomb

Original comment by necrosis...@googlemail.com on 18 Feb 2010 at 9:03

[GoogleCodeExporter]

At the top level for more match context i added

weatherChanges.. this is a list of the weather during the game
inducements - a list of inducements taken

At the team level the following new attributes were added

(mostly for match context)
race
coach
rerolls
teamValue

(but also rotters for after match info)
rotters - number of rotters

Original comment by necrosis...@googlemail.com on 18 Feb 2010 at 9:06

[GoogleCodeExporter]

Also added the attribute to players for more context

position

(this allows you to work out the type of mercenary taken as inducement)

Original comment by necrosis...@googlemail.com on 18 Feb 2010 at 9:08

[GoogleCodeExporter]

r607 has this ready. Up to you to add the new IRs William, then I think this is 
done
for now...

Original comment by Nimda...@gmail.com on 18 Feb 2010 at 9:57

[GoogleCodeExporter]

ok done.  I have everything uploaded.  I told necrosis of an XSD error and I 
got this
error as well:

Warning: mysql_fetch_assoc(): supplied argument is not a valid MySQL result 
resource
in /lib/class_match.php on line 326

Warning: array_merge() [function.array-merge]: Argument #2 is not an array in
/lib/class_match.php on line 352
Upload was successful.

Besides the error everything looks good.  I wonder if it is because it is 
basically a
duplicate match that I allowed through.  Trying another new match shortly.

Original comment by funnyfin...@hotmail.com on 19 Feb 2010 at 2:17

[GoogleCodeExporter]

Ok that error is gone now and it looks like all but the XSD is complete now.

Thanks everyone!

Original comment by funnyfin...@hotmail.com on 19 Feb 2010 at 3:54

[GoogleCodeExporter]

what was the problem?

Original comment by Nimda...@gmail.com on 19 Feb 2010 at 7:16

[GoogleCodeExporter]

That error must have come from the fact that the match was for a previous match 
and I
allowed it to be uploaded again and referenced some dead players I suppose.

Original comment by funnyfin...@hotmail.com on 19 Feb 2010 at 2:49

[GoogleCodeExporter]

So this works? Can we close it?

Original comment by Nimda...@gmail.com on 19 Feb 2010 at 6:45

[GoogleCodeExporter]

Let's wait for the XSD.

Original comment by funnyfin...@hotmail.com on 19 Feb 2010 at 6:47

[GoogleCodeExporter]

What is it precisely? I can see that he changed the .xsd too?

Original comment by Nimda...@gmail.com on 20 Feb 2010 at 9:39

[GoogleCodeExporter]

I fixed it.  Strange that the java validation did not catch it.

Original comment by funnyfin...@hotmail.com on 20 Feb 2010 at 4:14

• Changed state: Fixed

[GoogleCodeExporter]

Hrm, I feel that the match report page became a bit cluttered now with the 
additional
IR pairs.

May I suggest using javascript to add another row just under the player row if
something is entered in the first IR fields?

I'm attaching a mock-up of how it could look and feel.

Original comment by setomi...@gmail.com on 26 Feb 2010 at 7:33

Attachments:

• matchreport.zip