Manage extra player value is doubled in 0.8

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Add +30k once using the admin tools "Manage extra player value"
2. The player will now cost 60k more than he originally did.

What is the expected output? What do you see instead?

The player should only cost the extra value indicated in the admin instruction. 
Instead, the value is doubled.

What version of the product are you using?

OBBLM 0.8. I don't think this bug presented itself in 0.75.

Please provide any additional information below.

We first noticed this when dealing with a team that won the Chaos Cup and was 
then awarded 2 free mutations. The mutations don't count against SPP, so the 
skill and value for the skill had to be added by admins. 

The coach noticed after upgrading to 0.8 that his mutated players were 30k too 
expensive. My kludge was to halve the expected additional value. The following 
team sheet is now using an added value of 15k for the 2 players with mutations:
http://www.thunderbowl.ca/tbsn/index.php?section=objhandler&type=1&obj=2&obj_id=
162&subsec=man#anc

Original issue reported on code.google.com by kavi...@gmail.com on 23 Sep 2010 at 2:33

[GoogleCodeExporter]

What id you add the value to players who have never had the additional value 
prior to the upgrade?

Original comment by funnyfin...@hotmail.com on 25 Sep 2010 at 1:09

[GoogleCodeExporter]

Hi Will,

Player #14 was given the Claw skill and we added 30k to his value. It shows up 
as 50k+60k= 110k. It should only be 80kgp. 

What we found is that the team TV is correct when we use +30k. The team TV is 
incorrect when we kludge it by halving the extra player cost 15k (player cost 
is now good but the team TV is incorrect).

I tried hunting for an obvious sign that the player cost formula is doubling 
the extra cost. I couldn't find an obvious source in the code, is it possible 
that this error is happening in SQL rather than through PHP?

Original comment by kavi...@gmail.com on 27 Sep 2010 at 8:40

[GoogleCodeExporter]

Try running a syncall() from the admin control panel.

Original comment by funnyfin...@hotmail.com on 28 Sep 2010 at 12:47

[GoogleCodeExporter]

Thanks, just tried it and unfortunately no change.

Original comment by kavi...@gmail.com on 28 Sep 2010 at 4:51

[GoogleCodeExporter]

Just to let you know, it does work for me fine.

Original comment by funnyfin...@hotmail.com on 28 Sep 2010 at 7:35

[GoogleCodeExporter]

And I don't think that this is the problem, but it is not add extra player 
value, it is set extra player value.

Original comment by funnyfin...@hotmail.com on 28 Sep 2010 at 7:43

[GoogleCodeExporter]

Thanks. Hmm, could it be platform related? Where is the player value 
calculated? My assumption was that it is figured out on the fly per page view. 
Is this correct? If so, is this entirely PHP dependent or could one of the 
stored SQL functions be involved?

Original comment by kavi...@gmail.com on 28 Sep 2010 at 9:23

[GoogleCodeExporter]

I can't reproduce this. Is the result the same if you do a fresh install?

Most of the values are stored and rely on SQL routines to update them etc.., 
can't remember right now, if the total player value is a pre-calculated and 
stored result too. Either way, it should be updated when changing the extra 
player value.

Original comment by Nimda...@gmail.com on 19 Oct 2010 at 10:24

• Added labels: OBBLM_core, Priority-High
• Removed labels: Priority-Medium

[GoogleCodeExporter]

Bump...

Original comment by Nimda...@gmail.com on 29 Dec 2010 at 3:25

[GoogleCodeExporter]

Closing this if you do not respond soon (can't reproduce it).

Original comment by Nimda...@gmail.com on 6 Feb 2011 at 11:52

[GoogleCodeExporter]

Original comment by Nimda...@gmail.com on 10 Mar 2011 at 6:35

• Changed state: WontFix