williamleonard / obblm

Automatically exported from code.google.com/p/obblm
1 stars 0 forks source link

The Infocus box displays incorrectly if there are more than one standings boxes #471

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Issue can be checked in this url:

http://nbbl.hackerbunny.net

After a correct first display of the info, the first infocus box will display 
with defects and the second one will not display any info at all.

I have also tested it with more than 2 boxes, with the same result.

Tested with Firefox and Opera.

This issue might be connected to closed issue 428.

As a possible workaround, maybe a setting for the standing box array could be 
created, allowing to choose whether to show or not the infocus box for each 
standing box.

Original issue reported on code.google.com by hackerbunny@gmail.com on 6 Nov 2010 at 3:13

GoogleCodeExporter commented 9 years ago
I have mailed setomidor about this.

I think it's due to the CSS/HTML div IDs and such.

Original comment by Nimda...@gmail.com on 6 Nov 2010 at 11:40

GoogleCodeExporter commented 9 years ago
Ok, let me know if you need more info or help with this one.

Original comment by hackerbunny@gmail.com on 7 Nov 2010 at 8:21

GoogleCodeExporter commented 9 years ago
Issue noted, I'll try to look at this during the day. :)

Original comment by setomi...@gmail.com on 10 Nov 2010 at 9:33

GoogleCodeExporter commented 9 years ago
Ok, the cause is clear but I'm not sure what the best fix is. Let me elaborate;

The module was originally designed to be used once per league, which of course 
also means (at most) once per page. As Nicholas already guessed, the JavaScript 
targets the ID of the InFocus div to fade in the different "pages".

Running two boxes at the same page currently means two different scripts are 
targeting the same div of the first box, which causes the strange behavior. It 
also means NO script targets the second box, which means it never starts.

Comparing the current trunk to the version I've worked with before, it seems 
the manner in which the front-page boxes are generated has changed. The 
call-out to the InFocus module is now made within the standings table, so if 
you have two standings you automatically have two infocus boxes (which 
currently breaks). (This also causes the InFocus box to be generated inside the 
BoxWide-Div of the Standings table, which is why the layout is slightly broken.)

Personally, I think that one box per league is sufficient and having more than 
one box might be a bit "too much". Do people agree with this or is someone keen 
on running more than one box?

If people agree with this, I suggest that the call-out for the InFocus module 
is moved back outside the code generating the standings table, treating it as 
any of the other stand-alone boxes. This means only one box is generated per 
league, and so the parallel-scripts problem is unreachable. Also, the layout 
problems will be fixed. :)

Original comment by setomi...@gmail.com on 11 Nov 2010 at 7:34

GoogleCodeExporter commented 9 years ago
I agree. For my leagues, one In-Focus box is more than enough.

Original comment by hackerbunny@gmail.com on 11 Nov 2010 at 3:39

GoogleCodeExporter commented 9 years ago
I also agree.

Original comment by Nimda...@gmail.com on 14 Nov 2010 at 3:02

GoogleCodeExporter commented 9 years ago
Would you look at this?

Original comment by Nimda...@gmail.com on 8 Feb 2011 at 12:50

GoogleCodeExporter commented 9 years ago
Any advance on this issue?

Original comment by hackerbunny@gmail.com on 21 Mar 2011 at 9:40

GoogleCodeExporter commented 9 years ago
Don't think so, setomidor has not responded...

Original comment by Nimda...@gmail.com on 21 Mar 2011 at 12:42

GoogleCodeExporter commented 9 years ago
r777

Original comment by Nimda...@gmail.com on 17 Apr 2011 at 5:20

GoogleCodeExporter commented 9 years ago
Nice solution.

But why not allow it for leagues also? Why only tournament standing boxes?

Original comment by hackerbunny@gmail.com on 19 Apr 2011 at 12:19

GoogleCodeExporter commented 9 years ago
Don't really know why I did that. Thought that the old implementation was like 
that too - just copied it :-).

r786 has this fixed (allows all node types).

Original comment by Nimda...@gmail.com on 20 Apr 2011 at 9:42