[Android Bootcamp] Project 3: Sweeter - Ready for Review

[williamlian]

My app is complete, please review. /cc @codepathreview @codepath

Issue for this assignment: I want to dynamically set a max height of a dialog. The detail view dialog, when there are no media it is good to stay as the height to wrap the content, but when there are media it will stretch to the top and bottom of the screen which is not good looking. So basically I want to set the height of the dialog at runtime by checking if the measured height of the dialog is larger than a threshold, if so then set it to be fixed at the threshold. I searched around and tried the getDecorView(), getMeasureHeight() but all of the methods give me 0 as the runtime height of the dialog.

[codepathreview]

:+1: Excellent work. Great to see you put in the effort to turn in a polished assignment.. A few notes after checking out the code:

• Good to see you were able to format the timestamp relatively.
• Nice to see you used the SwipeRefreshLayout for easy timeline refreshes
• Good to see you refreshed the timeline after composing a new tweet
• Great job implementing the compose tweet feature as a dialog
• Good to see you added ActiveAndroid annotations to the models for offline usage
• Nice touch with the character count being displayed while the user composes a tweet and disabling the tweet button if the count exceeds 140 chars.
• Great job adding retweet/favorite functionalities.

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.