search

williamparry / cloudRIG

Stream your applications with Parsec and AWS on the cheap.
MIT License
155 stars 28 forks source link

New version available banner UI bug #103

Closed williamparry closed 5 years ago

williamparry commented 5 years ago

The loading panel covers part of the banner.

screen shot 2018-10-06 at 12 33 58 pm

You can trigger the banner manually by flipping the condition here: https://github.com/williamparry/cloudRIG/blob/master/gui/react/src/components/App.js#L337

Would be good to tidy up the grid and lessen the padding of the console.

gowrimanoharir commented 5 years ago

Hi, I would like to work on this issue. I did not find a Contribution guidelines, could you please let me know of anything i should keep in mind, while trying to fix this issue? Thanks.

williamparry commented 5 years ago

Awesome. It uses https://react.semantic-ui.com/ and some custom styles in App.css mostly to fix heights. It would be good to remove those "fixes" as part of the issue.

You should be able to emulate the conditions without needing to set up cloudRIG (it sets up AWS infrastructure). You'll need to test on macOS (or Ubuntu/Windows if you can get them to compile).

gowrimanoharir commented 5 years ago

@williamparry thanks for additional info, I work in windows. But anyways looks like someone has already fixed it though.

williamparry commented 5 years ago

Looks like their fix is only partial, and moves it into the wrong place. It's still open if you'd like to look :)

gowrimanoharir commented 5 years ago

thats gr8, thanks. I will try to set up my local and get going

dmhalejr commented 5 years ago

@gowrimanoharir Incomplete PR author here. :) Also on Windows. I had to run yarn install for every package.json that was available in every folder under gui to get it working. So that's electron, react, and gui.

Then I just ran yarn start at the gui folder level and it spun up my local environment correctly.

Windows Environment: Windows 10 NVM Version 1.1.7 Node Version 10.9.0

To get around the configuration screen modal -- I just generated a dummy .aws file and uploaded it into the local environment with fake entries. That'll get you to the place to start making the complete changes. I hope this helps!

williamparry commented 5 years ago

@dmhalejr legend - thanks mate

gowrimanoharir commented 5 years ago

@dmhalejr thanks for the info. @williamparry below are few screenshots of fixed panel issue. Also pls note that I am testing by hard coding the required page template in line 200 for currentPage; If need to test it differently or any more cases pls let me know.

For console UI styling itself the top grid is having a fixed height of 476px, is that needed? I am trying with some %height for the top and bottom panels. Works for most part with some items to fix, but wanted to confirm with you before going deep, would that be ok instead of fixed height?

configuration processing settingup

gowrimanoharir commented 5 years ago

FYI - changes made for above - https://github.com/gowrimanoharir/cloudRIG/commit/ec3779a8ca21e5cbad2dc0786c92585e36eef568