williamrijksen / com.williamrijksen.onesignal

Titanium Appcelerator Library for OneSignal Push Notifications Service
Other
51 stars 43 forks source link

Library version 2.1.2 does not work in Android 12 SDK #112

Open fusionqb opened 1 year ago

fusionqb commented 1 year ago

Starting on Nov 2022, the app cannot build to support Android 12. It requires Receiver FAILURE: Build failed with an exception. Execution failed for task ':lib.com.williamrijksen.onesignal:processReleaseManifest'. [ERROR] [GRADLE] > A failure occurred while executing com.android.build.gradle.tasks.ProcessLibraryManifest$ProcessLibWorkAction

[ERROR] [GRADLE] android:exported needs to be explicitly specified for . Apps targeting Android 12 and higher are required to specify an explicit value for android:exported when the corresponding component has an intent filter defined. See https://developer.android.com/guide/topics/manifest/activity-element#exported for details.

Will there be any update version for this change?

m1ga commented 1 year ago

please test https://github.com/williamrijksen/com.williamrijksen.onesignal/pull/115

fusionqb commented 1 year ago

It doesn't work on Android SDK 33 - Google Play Services Library Error

m1ga commented 1 year ago

did you follow the readme in the PR? https://github.com/williamrijksen/com.williamrijksen.onesignal/blob/87a8fabd33a38da7d9c4c2befd113b2ace65ff86/README.md#android

I'm not using the module but when I use the file from the PR I can build a simple test app with the module and it builds fine. Android 14, Pixel 7, Ti 12.1.2.GA

When do you see the error?

fusionqb commented 1 year ago

In the onesignal log, it shows Google Play services library initialization error. Check for conflicting plugins and make sure com.google.android.gms.version is in your androidmanifest.xml onesignal image

m1ga commented 1 year ago

maybe that phone doesn't have playservices installed or active? Can't help you with anything onesignal related as I'm not using it. What you can do is search for AndroidManifest.xml in your build folder and check those files (the bigger once) for the entry <meta-data android:name="com.google.android.gms.version" android:value="@integer/google_play_services_version" />. That should be there as soon as you use ti.playservices