search

williamrijksen / com.williamrijksen.onesignal

Titanium Appcelerator Library for OneSignal Push Notifications Service
Other
51 stars 43 forks source link

The behavior of notificationReceived on Android is the same as iOS. #37

Closed gimdongwoo closed 7 years ago

gimdongwoo commented 7 years ago

On Android, additionalData must be present for notificationReceived event to occur.

Even if there is only Title and Body, it is need to fire event.

The iOS version in your module is working like that.

Because, I'm make to the behavior of notificationReceived on Android is the same as iOS.

I confirmed that I built it and it works, but your policy did not seem to upload the module zip file, so I omitted it.

Thank you!

jvandijk commented 7 years ago

@gimdongwoo thank you submitting this PR. I'm closing this now in favor of #38 which incorporates your addition, but on top of that exposes everything in the payload that OneSignal sends.

And yes, we don't distribute the zip file because the build process is automated based on git tags.