search

williamrijksen / com.williamrijksen.onesignal

Titanium Appcelerator Library for OneSignal Push Notifications Service
Other
51 stars 43 forks source link

Updating OneSignalSDK to v3.10.1 #73

Closed jordansilva closed 5 years ago

jordansilva commented 6 years ago

I've just updated OneSignal SDK from v3.8.0 to v.3.10.1 for Android everything seems fine!

adriendillens commented 6 years ago

@williamrijksen production apps need to be updated ASAP (Samsung & OnePlus on Android 8.0 / 8.1 don't receive notifications at all -> background app & killed app). Fast module release will be really appreciated ;-)

jordansilva commented 6 years ago

@adriendillens did you have tested the last release using v3.8.0 onesignal SDK?

adriendillens commented 6 years ago

@adriendillens did you have tested the last release using v3.8.0 onesignal SDK?

Yes of course, i'm using it for 3 months (onesignal 2.0.1 with android SDK 3.8.0) Disable battery optimization on users devices doesn't resolve problem In addition, users receive notifications from other apps that uses FCM / GCM instead of onesignal

jordansilva commented 6 years ago

@adriendillens Are you testing in which device? Because I've tested using Samsung devices and it is working.

adriendillens commented 6 years ago

@jordansilva not working :

jordansilva commented 6 years ago

I'm not sure that will solve the problem.

I've tested (with this SDK update) on Motorola X2, Samsung S7, Samsung S9, and Moto G4. Tested using Android 6, 7 and 8 versions. Have you checked this last comment in this thread? https://stackoverflow.com/a/42250725/2005273

Send me a private message tomorrow (in Hangouts) and I help you to test the module locally and we can check if the SDK update will fix this issue.

On Tue, Sep 18, 2018 at 6:02 PM adriendillens notifications@github.com wrote:

@jordansilva https://github.com/jordansilva not working :

  • Oneplus 5 (A5000) Android 8.1.0 -> no notification received
  • Samsung (SM-A320FL) Android 8.0.0 -> only vibrate, but no notification visible These devices owns to beta testers, i can't see the logs for now ... But, it seems to be related to #71 https://github.com/williamrijksen/com.williamrijksen.onesignal/issues/71 Onesignal Android SDK update should fix these problems right ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/williamrijksen/com.williamrijksen.onesignal/pull/73#issuecomment-422450448, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGKVm7SC_wL8cBqnSEC-rSREgBmWD21ks5ucRkQgaJpZM4WsQEB .

joshualambert commented 5 years ago

@jordansilva Has this still been working without issues in production for you?

jvandijk commented 5 years ago

Closing in favor of #79