search

williamrijksen / com.williamrijksen.onesignal

Titanium Appcelerator Library for OneSignal Push Notifications Service
Other
51 stars 43 forks source link

- Updated Android OneSignal SDK to 3.15.1 - Realease 2.1.2 Android, 2… #98

Closed AbdullahFaqeir closed 4 years ago

AbdullahFaqeir commented 4 years ago
chmiiller commented 4 years ago

Hey @AbdullahFaqeir thanks for this one, but I figured out how to update it and I'm making 2 new releases (like you did): one for iOS on version 2.2.2 and one for Android on version 2.1.2. Besides the new One Signal SDKs, they merge my new setExternalUserId/removeExternalUserId methods + your "retrieve" methods. I think I will close this PR without merging it if you don't mind

chmiiller commented 4 years ago

These are the new releases: https://github.com/williamrijksen/com.williamrijksen.onesignal/releases/tag/2.1.2 on Android and https://github.com/williamrijksen/com.williamrijksen.onesignal/releases/tag/2.2.2 on iOS

AbdullahFaqeir commented 4 years ago

@chmiiller good job, of course I don't mind, and please poke me if you needed any help updating this module in the feature. Again, glad I helped with this.

chmiiller commented 4 years ago

Awesome work! Thanks for it and we can talk more on Titanium Slack (ti-slack.slack.com)

AbdullahFaqeir commented 4 years ago

@chmiiller can you please send me an invitation? abdullah(@)devloops(.)net