williamtroup / Calendar.js

📅 A javascript drag & drop event calendar, that is fully responsive and compatible with all modern browsers.
https://calendar-js.com
MIT License
478 stars 33 forks source link

Remove "st", "nd", "rd" and "th" in translations #231

Closed Eloitor closed 3 months ago

Eloitor commented 3 months ago

Describe the bug Some translations shouldn't use "st", "nd", "rd" and "th" in the numbers of the days.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://calendar-js.com/examples/translations.html
  2. See "st", "nd", "rd" and "th" in the numbers of the days.

Expected behavior Day numbers should be "1", "2", "3", ... without "st", "nd", "rd" and "th".

williamtroup commented 3 months ago

Which translation file is this for?

Eloitor commented 3 months ago

spanish ant catalan at least.

williamtroup commented 3 months ago

Fixed and released in v2.10.16.

Eloitor commented 3 months ago

After updating it still shows "st", "nd", "rd", and "th"...

imatge

They are still present in the examples: https://calendar-js.com/examples/translations.html

williamtroup commented 3 months ago

Yes, I've discovered a small issue. Will get this fixed and issued in the next release.

williamtroup commented 3 months ago

I've just released v2.10.17 which fixes this issue, and fixes issues around other empty strings being used.