View state such as rating is not restored from instance state

williamyyu / SimpleRatingBar

A simple RatingBar that you can easier to customize image and animations

MIT License

1.36k stars 153 forks source link

View state such as rating is not restored from instance state #35

Closed harshsharma94 closed 7 years ago

harshsharma94 commented 7 years ago

When activity/fragment is recreated, savedInstanceState is not restored for RatingBar. Cause: Need to save rating state in parcel How to reproduce: Turn on the flag, "Don't keep activities" in Developer Options. And revisit sample Activity after setting rating.

I do have a PR which solves this issue. Can you have a look ?

williamyyu commented 7 years ago

Hello @harshsharma94 , Thanks for your help!! but I don't see any PR, could you send it again? Thanks!

harshsharma94 commented 7 years ago

PR created.

williamyyu commented 7 years ago

Thank you very much! I'll take a look this weekend.

williamyyu commented 7 years ago

Hello, I have accepted the PR, Thanks again for your help!