williamyyu / SimpleRatingBar

A simple RatingBar that you can easier to customize image and animations

MIT License

1.36k stars 153 forks source link

Fix ExampleProject #5

Closed nappannda closed 7 years ago

nappannda commented 7 years ago

MainActivity

add baseRatingBar and rotationRatingBar Log

RatingBar

delete

activity_main.xml

sort layout
fix id name

strings.xml

add string

williamyyu commented 7 years ago

Hello, Thanks for helping me to arrange these file! but, there has one thing I think maybe you can modify and send a PR again, is about the ID naming.

I used to make the object name at the first, like tvScale or tv_scale. Here are some references maybe you can take a look:

Code Style for Contributors
A successful XML naming convention

Hope these can help you! If you have any different ideas or references, welcome to share with me. Thanks again!

nappannda commented 7 years ago

Hello, Thanks for the reference! I looked at the reference and tried changing it