search

williamyyu / SimpleRatingBar

A simple RatingBar that you can easier to customize image and animations
MIT License
1.37k stars 152 forks source link

match_parent not work #62

Closed LSDsl closed 4 years ago

LSDsl commented 6 years ago

When set layout_width to match_parent stars not use all width. Expectation - it add spaces between stars to use all width. Is it possible?

williamyyu commented 6 years ago

Hi @LSDsl,

Thanks for issued this feature, I'll try to implement this recently.

alonfi commented 4 years ago

Hi @ome450901, did you get a chance to look into the match_parent issue? Setting a fixed srb_starPadding causes the stars to be cut off if the screen is not wide enough to contain the total width of the stars and their set padding. It would be convenient if the padding would be dynamic and change according to the parent's width.

In addition, it would be nice if different starPadding values could be set on different sides of the star, for example add padding horizontally between the stars, but don't add padding vertically above and below the stars.

williamyyu commented 4 years ago

Hi @alonfi Sorry I haven't started working on it yet, it's quite busy at the moment. Thanks for the suggestion though, I'll try to have a look over the weekend.

williamyyu commented 4 years ago

Fixed commit