search

williamyyu / SimpleRatingBar

A simple RatingBar that you can easier to customize image and animations
MIT License
1.36k stars 153 forks source link

setOnRatingChangeListener infinate loop #68

Closed ShahabGT closed 5 years ago

ShahabGT commented 5 years ago

Hello, there is a big flow with this library (at least i think so). my app has a rating system that you can rate a shop from 1 to 5 stars. the problem is on setOnRatingChangeListener i want to send the selected rate to a server and refresh the rating bar with the received data from the server. so when it happens the setOnRatingChangeListener will trigger and it becomes an infinite loop. ps. in android RattingBar in setOnRatingBarChangeListener there is a boolean value called fromUser which will determine a user selected that value or it's been set from code. THIS IS what your library missing.

williamyyu commented 5 years ago

Hi @ShahabGT, Thanks for raising the issue, I'll put this into TODO list.

jcholin commented 5 years ago

Hi @ome450901, Any hope to have a new release with this fix? thx

williamyyu commented 5 years ago

Hi @jcholin , Just released 1.4.3 to fix this issue, thanks.