search

willianjusten / nba-remix

A simple app to show NBA games and scores/details.
https://nba.willianjusten.com.br
210 stars 31 forks source link

Add TeamInfo component - closes #35 #44

Closed helderberto closed 2 years ago

helderberto commented 2 years ago

Created a component for the following UI:

Screenshot 2022-02-16 at 14 09 20 Screenshot 2022-02-16 at 14 09 29

I moved the types that are shared into the application to the app/types.ts. What do you think about that?

closes #39

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/willianjusten/nba-remix/2Hrjha1NJpeHfNdZDwrdxriCCCvq
✅ Preview: https://nba-remix-git-add-teaminfo-subcomponent-willianjusten.vercel.app

jdrgoms commented 2 years ago

@helderburato good move! so it becomes much clearer. 👍🏾

helderberto commented 2 years ago

Thanks @jdrgomes!

I'm just in doubt about the type of GameList, because it is very similar to the Game, but I think you can normalize the data in the near future to keep using the same type. What do you think?