willianjusten / nba-remix

A simple app to show NBA games and scores/details.
https://nba.willianjusten.com.br
208 stars 31 forks source link

Feat: Adding "Go to today" button - closes #87 #88

Closed Hedg0305 closed 2 years ago

Hedg0305 commented 2 years ago

The feature is mostly working, however, I am trying to fix the bug which occurs when you click a button on the overlay and then click outside the overlay but it remains visible.

This bug was reported here: https://github.com/gpbl/react-day-picker/issues/723

vercel[bot] commented 2 years ago

Someone is attempting to deploy a commit to a Personal Account owned by @willianjusten on Vercel.

@willianjusten first needs to authorize it.

Hedg0305 commented 2 years ago

FYI: This bug is also happening at the master branch.

Steps to reproduce it:

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/willianjusten/nba-remix/AZZfpHqauruvqZW5EVX5ypEimeVD
✅ Preview: https://nba-remix-git-fork-hedg0305-add-today-btn-04a92a-willianjusten.vercel.app

marcosdoriguetto commented 2 years ago

One thing that I think can be cool too, is to increase the font weight and put its color equal to the hover of the selected date.

Something like that:

.DayPicker-TodayButton {
  font-weight: 500;
  color: #3b82f6;
}

or add this properties on .DayPicker-Footer, what do you think?

willianjusten commented 2 years ago

I didn't have time to look at the code yet, but I'm having a bug not being able to close the calendar. If I click "go to Today" it goes to the right URL but I can't close it...

Hedg0305 commented 2 years ago

Yep, this bug is happening, I mentioned in the comment above.

willianjusten commented 2 years ago

Since #89 did the same but in a simpler way and didn't cause any bugs, I merged it and I'm closing this one here. Thanks =)