search

williankeller / magento2-facebook-pixel

This free Facebook Pixel extension allows you to track your visitors' actions.
Open Software License 3.0
36 stars 15 forks source link

Option dropdown that controls tax isn't informative #12

Closed erfanimani closed 3 years ago

erfanimani commented 3 years ago

It simply says Settings — Enabled (store/config), no indication that this is actually controlling whether price tracking includes tax or not.

williankeller commented 3 years ago

Hi @erfanimani, what's your suggestion here?

erfanimani commented 3 years ago

See PR here: https://github.com/magestat/magento2-facebook-pixel/pull/14

Changed "Enabled" to "Include tax", and added comment. (The enabled label must have been copy/paste leftover)

Also, as far as I can see it only controls product price. Checkout grand total always includes tax. Correct me if I'm wrong.