search

williankeller / magento2-facebook-pixel

This free Facebook Pixel extension allows you to track your visitors' actions.
Open Software License 3.0
36 stars 15 forks source link

HTML validation error #15

Closed erfanimani closed 3 years ago

erfanimani commented 3 years ago

An img tag appears in a noscript tag within <head>. Image tags can't appear within the document head.

Moreover, the entirety of pixel-code.phtml could be moved to the body, or before-body-end container, as I believe the RequireJS javascript only kicks in after the whole page is loaded anyway. For scripts initialized with "text/x-magento-init" it shouldn't make a difference whether it's located in the head, or body.

Are you happy for me to create a PR @williankeller ?

williankeller commented 3 years ago

Hi @erfanimani, it would be great if you help us out here! It would be much appreciated!