willianmano / moodle-theme_moove

A Moodle Boost child theme
GNU General Public License v3.0
170 stars 155 forks source link

Hidden items being counted towards course completion percentage #449

Closed alexfoffano closed 4 months ago

alexfoffano commented 6 months ago

Describe the bug Restricted and hidden items and activities are being counted towards course completion percentage. I just updated my Moodle from 3.11 to 4.1 and I've noticed this. I've been using the Moove theme for a long time and it used to disconsider these hidden activities.

To Reproduce Steps to reproduce the behavior:

  1. Create a new course
  2. Create two activities
  3. Mark one activity as done
  4. Make the other as hidden
  5. See the course completion percentage, it is 50%

Expected behavior I believe the course completion percentage should count only the visible activities.

Your environment (please complete the following information):

willianmano commented 4 months ago

@alexfoffano Thanks for reply this, but this is a Moodle issue, as we use moodle core API to get the course progress.