willianrod / ODeck

A free and open-source alternative to StreamDeck
https://odeck.app
MIT License
388 stars 22 forks source link

[bug] cannot open OBS executable #16

Closed willianrod closed 1 year ago

willianrod commented 1 year ago

Reported by: eujeffz

Expected Behavior

Open OBS correctly without any issues

Current Behavior

While trying to open OBS, an error is show. The error is coming from OBS failing to start properly. Tried with some other executables and works fine, just OBS that is having issues.

Steps to Reproduce

  1. Add a key to open an executable

  2. Select obs.exe inside obs folder obs-studio\bin\64bit\obs64.exe

  3. Hit save

  4. Press the key to open OBS in your deck

  5. You should see the error below now image

Possible Solution (Not obligatory)

Maybe we need to open OBS not as a child process? Just guessing

Context

Your Environment

EduardoJM commented 1 year ago

Maybe we need to open the process changing the cwd option to the executable path (see node child process documentation):

https://nodejs.org/api/child_process.html#child_processexecfilefile-args-options-callback

I can try to work on this bug

willianrod commented 1 year ago

@EduardoJM I didn't take the time to investigate but doing this should probably fix the issue. You can take this one if you want. Just confirm your interest and I'll assign you

EduardoJM commented 1 year ago

Assign it to me, i will work on it today