search

williaster / data-ui

A collection of data-rich UI components πŸ“ˆ
https://williaster.github.io/data-ui/
MIT License
546 stars 69 forks source link

fix(xy-chart/BarSeries): fix negative value rendering, update stories #192

Closed williaster closed 4 years ago

williaster commented 4 years ago

πŸ› Bug Fix

This fixes an issue in @data-ui/xy-chart where negative y values render incorrectly for BarSeries. Updates the demo to include such y values.

Before (look at tooltips)

After

@conglei @kristw

codecov[bot] commented 4 years ago

Codecov Report

Merging #192 into master will decrease coverage by 0.03%. The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
- Coverage    80.5%   80.47%   -0.04%     
==========================================
  Files         109      109              
  Lines        2432     2433       +1     
  Branches      570      571       +1     
==========================================
  Hits         1958     1958              
  Misses        291      291              
- Partials      183      184       +1
Impacted Files Coverage Ξ”
packages/xy-chart/src/series/BarSeries.jsx 93.33% <90%> (-1.59%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update c2a6628...423f319. Read the comment docs.