Open williaster opened 4 years ago
Merging #195 into master will increase coverage by
0.01%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
+ Coverage 80.47% 80.49% +0.01%
==========================================
Files 109 109
Lines 2433 2435 +2
Branches 571 573 +2
==========================================
+ Hits 1958 1960 +2
Misses 291 291
Partials 184 184
Impacted Files | Coverage Δ | |
---|---|---|
packages/network/src/chart/Network.jsx | 75.3% <ø> (ø) |
:arrow_up: |
packages/shared/src/enhancer/WithTooltip.jsx | 81.25% <100%> (+1.25%) |
:arrow_up: |
packages/xy-chart/src/chart/XYChart.jsx | 76.51% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b63eb4a...b6384b5. Read the comment docs.
🏆 Enhancements
Currently if a user of
XYChart
orNetwork
passes their ownonMouseLeave
oronMouseMove
props in addition to arenderTooltip
prop, the mouse handlers are overwritten by theWithTooltip
provided mouse handlers and never invoked.This PR fixes this by
@data-ui/shared
sWithTooltip
to acceptonMouseLeave
andonMouseMove
functions, which are invoked when the provided equivalents are called.XYChart
andNetwork
to pass along the user-providedonMouseLeave
andonMouseMove
toWithTooltip
Test plan
WithTooltip