williaster / data-ui

A collection of data-rich UI components 📈
https://williaster.github.io/data-ui/
MIT License
546 stars 69 forks source link

Deprecated React lifecycle methods need to be renamed or removed #202

Closed kaiyoma closed 4 years ago

kaiyoma commented 4 years ago

When I use this library, I see console warnings like the following:

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: Histogram

At the very least, if you're not going to update to the new lifecycle methods, you need to rename the deprecated ones with UNSAFE_ at the beginning.

williaster commented 4 years ago

Please see #201