search

williballenthin / INDXParse

Tool suite for inspecting NTFS artifacts.
http://www.williballenthin.com/forensics/mft/indxparse/
Apache License 2.0
216 stars 42 forks source link

Transition INDXParse installation to using setup.cfg #46

Closed ajnelson-nist closed 1 year ago

ajnelson-nist commented 1 year ago

Commit 1 in this PR has a log message that documents the rationale. Reorganizing the code base and changing the build system seemed to necessitate doing many things in one patch. I'm happy to answer any questions.

ajnelson-nist commented 1 year ago

@williballenthin : After one formatting hiccup (I usually handle pre-commit with a Make target; I forgot to set that up in a new temporary clone), I think this PR is ready to merge if you have no questions.

williballenthin commented 1 year ago

Hey @ajnelson-nist

Thanks for these changes. The code changes look solid, so those will be easy to accept.

Transitioning to use setup.cfg is fine, though ultimately the world is moving to pyproject.toml so perhaps we can do that before long. That doesn't block this PR, though.

I think we should discuss the licensing and headers that you've added in this PR. INDXParse is Apache 2.0 licensed and I would like to keep it that way. I'm not sure if it's possible to license software on a line-by-line basis, but in any case, I'm not comfortable doing it here. Would you please contribute the changes in accordance with the existing project license?

I'm also happy to accept a prominent acknowledgement that NIST contributed to the project in the README and CONTRIBUTORS files, but I don't want to include the full headers that you've proposed on the files that you've touched. If you want to update the headers, something like # Alex Nelson contributed to this file during the course of their official duties at NIST. is fine.

Happy to discuss further - let me know what you think.

ajnelson-nist commented 1 year ago

Hi @williballenthin - I've condensed the inlined-header license text close to your suggestion. Please let me know if there is anything else you would like to change.

ajnelson-nist commented 1 year ago

Thank you, @williballenthin . I appreciate your care on the matter too.