search

williewillus / botania-fabric-issues

Temporary home for bug reports of Botania fabric alpha testing
1 stars 0 forks source link

Sparks don't stay on top of mana pools #77

Closed CammiePone closed 3 years ago

CammiePone commented 3 years ago

Something in the last few commits caused sparks to no longer stay on mana pools. They just instantly break.

williewillus commented 3 years ago

@Alwinfy I think this is caused by https://github.com/VazkiiMods/Botania/commit/c979962682efb76ddb6ce10721182ac9a7c3bf18

Reverting locally fixed it for me. Could you take a look?

Hubry commented 3 years ago

Looks like the faulty method is the new impl of getAttachPos()?

Hubry commented 3 years ago

So Alwinfy used getPositionUnderneath when the PR was targetting 1.16, but accidentally changed the target to the method called getOnPosition when updating the PR. The Mojang names of these two methods are getBlockPosBelowThatAffectsMyMovement and getOnPos on mojmap.

Anyways, VazkiiMods/Botania@018a4faf7360cf943c0a87ca004fe34f434c86d2