Closed chadmoone closed 10 years ago
This is in relation to our images, right? Historically we've had mixed case in our image files and often people do that, but I'm all for switching it.
@chadmoone do you want us to change the images to all lowercase? If so, I can get that done pretty quickly.
Yeah, I don’t remember exactly, but I think it was probably in relation to images. I know people sometimes use mixed cases in images, but I think it’s a bad practice for several reasons. I’d suggest changing them to lower-case whenever a big change like that is unlikely to cause conflicts.
-- Chad
From: Dillon Lucente notifications@github.com Reply: willinteractive/will-style reply@reply.github.com> Date: September 26, 2014 at 11:29:57 AM To: willinteractive/will-style will-style@noreply.github.com> Cc: Chad Moone cmoone@willinteractive.com> Subject: Re: [will-style] Don't use uppercase in file names (#35)
@chadmoone do you want us to change the images to all lowercase? If so, I can get that done pretty quickly.
— Reply to this email directly or view it on GitHub.
Yeah, ok. I think it’d be better to nip this in the bud. I’ll get them renamed in the repo, but we’ll just have to remember to continue this going forward.
-- Dillon Lucente WILL Interactive
On September 26, 2014 at 11:37:28 AM, Chad Moone (notifications@github.com) wrote:
Yeah, I don’t remember exactly, but I think it was probably in relation to images. I know people sometimes use mixed cases in images, but I think it’s a bad practice for several reasons. I’d suggest changing them to lower-case whenever a big change like that is unlikely to cause conflicts.
-- Chad
From: Dillon Lucente notifications@github.com Reply: willinteractive/will-style reply@reply.github.com> Date: September 26, 2014 at 11:29:57 AM To: willinteractive/will-style will-style@noreply.github.com> Cc: Chad Moone cmoone@willinteractive.com> Subject: Re: [will-style] Don't use uppercase in file names (#35)
@chadmoone do you want us to change the images to all lowercase? If so, I can get that done pretty quickly.
— Reply to this email directly or view it on GitHub. — Reply to this email directly or view it on GitHub.
I think exceptions for this, though, would be when the file name contains proper nouns or acronyms. For example, the WILL_logo should stay all caps for WILL. And if we ever use another company’s logo, or a person’s name, that should be capitalized as well.
No, there is not a good reason to use capital letters in any file name for web development. Using capital letters for some and not others just adds to the confusion.
-- Chad
From: chorn99 notifications@github.com Reply: willinteractive/will-style reply@reply.github.com> Date: September 26, 2014 at 11:41:44 AM To: willinteractive/will-style will-style@noreply.github.com> Cc: Chad Moone cmoone@willinteractive.com> Subject: Re: [will-style] Don't use uppercase in file names (#35)
I think exceptions for this, though, would be when the file name contains proper nouns or acronyms. For example, the WILL_logo should stay all caps for WILL. And if we ever use another company’s logo, or a person’s name, that should be capitalized as well. — Reply to this email directly or view it on GitHub.
Yeah, the biggest issue is that OS X is not case-sensitive but our production servers are. It can cause broken images.
-- Dillon Lucente WILL Interactive
On September 26, 2014 at 11:43:26 AM, Chad Moone (notifications@github.com) wrote:
No, there is not a good reason to use capital letters in any file name for web development. Using capital letters for some and not others just adds to the confusion.
-- Chad
From: chorn99 notifications@github.com Reply: willinteractive/will-style reply@reply.github.com> Date: September 26, 2014 at 11:41:44 AM To: willinteractive/will-style will-style@noreply.github.com> Cc: Chad Moone cmoone@willinteractive.com> Subject: Re: [will-style] Don't use uppercase in file names (#35)
I think exceptions for this, though, would be when the file name contains proper nouns or acronyms. For example, the WILL_logo should stay all caps for WILL. And if we ever use another company’s logo, or a person’s name, that should be capitalized as well. — Reply to this email directly or view it on GitHub. — Reply to this email directly or view it on GitHub.
I’ve never heard this idea anywhere. I’m mostly ok with it, but I strongly think that capitals should be used as they would if they were being written in a sentence. I think ‘WILL' versus ‘will' is confusing.
_CAROLINE HORN • _Ninja Designer 240.428.1014 • chorn@willinteractive.com
On Fri, Sep 26, 2014 at 11:43 AM, Chad Moone notifications@github.com wrote:
No, there is not a good reason to use capital letters in any file name for web development. Using capital letters for some and not others just adds to the confusion.
-- Chad
From: chorn99 notifications@github.com Reply: willinteractive/will-style reply@reply.github.com> Date: September 26, 2014 at 11:41:44 AM To: willinteractive/will-style will-style@noreply.github.com> Cc: Chad Moone cmoone@willinteractive.com> Subject: Re: [will-style] Don't use uppercase in file names (#35)
I think exceptions for this, though, would be when the file name contains proper nouns or acronyms. For example, the WILL_logo should stay all caps for WILL. And if we ever use another company’s logo, or a person’s name, that should be capitalized as well. — Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub https://github.com/willinteractive/will-style/issues/35#issuecomment-56979233 .
Yeah, actually OS X can be, but the default file system format is not.
-- Chad
From: Dillon Lucente notifications@github.com Reply: willinteractive/will-style reply@reply.github.com> Date: September 26, 2014 at 11:44:55 AM To: willinteractive/will-style will-style@noreply.github.com> Cc: Chad Moone cmoone@willinteractive.com> Subject: Re: [will-style] Don't use uppercase in file names (#35)
Yeah, the biggest issue is that OS X is not case-sensitive but our production servers are. It can cause broken images.
-- Dillon Lucente WILL Interactive
On September 26, 2014 at 11:43:26 AM, Chad Moone (notifications@github.com) wrote:
No, there is not a good reason to use capital letters in any file name for web development. Using capital letters for some and not others just adds to the confusion.
-- Chad
From: chorn99 notifications@github.com Reply: willinteractive/will-style reply@reply.github.com> Date: September 26, 2014 at 11:41:44 AM To: willinteractive/will-style will-style@noreply.github.com> Cc: Chad Moone cmoone@willinteractive.com> Subject: Re: [will-style] Don't use uppercase in file names (#35)
I think exceptions for this, though, would be when the file name contains proper nouns or acronyms. For example, the WILL_logo should stay all caps for WILL. And if we ever use another company’s logo, or a person’s name, that should be capitalized as well. — Reply to this email directly or view it on GitHub. — Reply to this email directly or view it on GitHub. — Reply to this email directly or view it on GitHub.
It's very common practice. File names are resource locators and not sentences, and there are a number of issues that can arise from using mixed cases in web development, so it's best to keep them consistent.
https://github.com/rails/rails/tree/master/guides/assets/images
If we are going to do this then we need to make sure that we have alt text on all images and not rely on the screen reader correctly reading the name of the image file.
Will the screen reader read WILL_Logo_20 and will_logo_20 differently?
-- Dillon Lucente WILL Interactive
On September 29, 2014 at 6:47:57 PM, chorn99 (notifications@github.com) wrote:
If we are going to do this then we need to make sure that we have alt text on all images and not rely on the screen reader correctly reading the name of the image file.
— Reply to this email directly or view it on GitHub.
Sorry I guess I don’t mean screen reader, but like if somehow the image doesn’t get downloaded and they get the missing image button, we want the text that appears to be correctly labeled.
Yeah, I see what you’re saying. We should have alt text anyways. It’s good practice.
-- Dillon Lucente WILL Interactive
On September 29, 2014 at 6:50:25 PM, chorn99 (notifications@github.com) wrote:
Sorry I guess I don’t mean screen reader, but like if somehow the image doesn’t get downloaded and they get the missing image button, we want the text that appears to be correctly labeled. — Reply to this email directly or view it on GitHub.
It's bad practice.