search

willinteractive / will-style

WILL styles for webapps.
0 stars 0 forks source link

Find out why Flot charts aren't showing in IE8- #4

Closed chorn99 closed 11 years ago

chorn99 commented 11 years ago

The charts will now work in browsers that don't support HTML5 canvas.

However, IE7 is still struggling and I think it's because there is a line in the Flot.js that is throwing an error, but I don't know enough of JS to fix it.

Screen Shot 2012-12-24 at 12 41 18 PM

sstefanski commented 11 years ago

additionally, charts are not appearing on the Reports page in IE8

chorn99 commented 11 years ago

It DOES render in IE8, we have to figure out what's different in the implementation between the reports page and the trials page.

Screen Shot 2013-01-03 at 4 45 01 PM

chorn99 commented 11 years ago

The IE8 issue was fixed by: https://github.com/willinteractive/testbed/commit/a0ad5a3673d724d75856dc1f9696ec2163d6d5eb

sstefanski commented 11 years ago

This is fixed but there is still a discrepancy in the color theme between the reports page and the trials page. I don't know why the trials page isn't using the same colors as the reports.

sstefanski commented 11 years ago

okay, I see why they aren't using the same colors. But now that I think about it, that completion pie chart should probably only use the status colors. So this can be closed.