willinteractive / will-style

WILL styles for webapps.
0 stars 0 forks source link

Can we make a .app-page-header & .breadcrumb helper? #50

Closed chorn99 closed 9 years ago

chorn99 commented 9 years ago

So the .app-page-header is basically a wrapper with column options similar to the hideable-sidebar:

<header class="app-page-header">
  <div class="row">
    <div class="{column-size(s)} column">
    </div>
    <div class="{column-size(s)} column">
    </div>
  </div>
</header>

And the .breadcrumbs would use the Foundation syntax and be similarly setup to a dropdown list

<ol class="breadcrumbs">
  <li><a /></li>
  <li class="current"><a /></li>
</ol>

with also the ability to add any content within the <li> like a dropdown.

This will significantly help us in breaking out the _header partial so each view can have it's own (or share one) and will reduce the amount if/then statements while still using less duplicate html.

dillonlucente commented 9 years ago

OK, we have helpers for these now. I'm also going to make a header helper that we can use to simplify the process.

chorn99 commented 9 years ago

So the div's were combined too much. It needs to be:

<header class="app-page-header">
  <div class="row">
    <div class="{column-size(s)} column">
    </div>
    <div class="{column-size(s)} column">
    </div>
  </div>
</header>

not

<header class="row app-page-header">
    <div class="{column-size(s)} column">
    </div>
    <div class="{column-size(s)} column">
    </div>
</header>
dillonlucente commented 9 years ago

Yeah, it was one way on the tracker and another on access. I went with the tracker way, since the other way broke the tracker.

chorn99 commented 9 years ago

I'll fix the tracker if you can do it this way

chorn99 commented 9 years ago

Fixed in the tracker.

Can you also add a .unavailable option to breadcrumb li's?

dillonlucente commented 9 years ago

To all of them? You can also just add class: unavailable if it's just for some of them.