search

willir / cargo-ndk-android-gradle

Cargo NDK for Android projects
Apache License 2.0
55 stars 7 forks source link

Failure if local.properties is not present? #23

Open ianthetechie opened 8 months ago

ianthetechie commented 8 months ago

Please accept my apologies in advance if this is not a particularly well formulated issue, as I am a Rust developer first and a JDK developer like... 25th 😂

It seems like local.properties needs to be present, or the build just fails. I knew exactly enough about Gradle to be dangerous, but Im' confused by this since my autogenerated local.properties file specifically says not to commit it to git, and running GitHub actions there is, as far as I can tell, no reason this would be generated for you and no reason to create one in most cases.

For a concrete example, see this failed CI run: https://github.com/stadiamaps/ferrostar/actions/runs/6761866916/job/18377186924.

java.io.FileNotFoundException: /home/runner/work/ferrostar/ferrostar/android/local.properties (No such file or directory)

I fixed this by literally adding touch local.properties in my GitHub action. This seems to me like it should not be necessary. Am I missing something?